Adds the x86-64 assembler.

src/IceAssemblerX86Base.h

 //===- subzero/src/IceAssemblerX86Base.h - base x86 assembler -*- C++ -*---===//
 //
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Modified by the Subzero authors.
 //
 //===----------------------------------------------------------------------===//
 //
@@ skipping 296 matching lines @@
 
     TypedEmitRegRegImm RegRegImm;
     TypedEmitRegAddrImm RegAddrImm;
   };
 
   /*
    * Emit Machine Instructions.
    */
   void call(typename Traits::GPRRegister reg);
   void call(const typename Traits::Address &address);
-  void call(const ConstantRelocatable *label);
+  void call(const ConstantRelocatable *label); // not testable.
   void call(const Immediate &abs_address);
 
   static const intptr_t kCallExternalLabelSize = 5;
 
   void pushl(typename Traits::GPRRegister reg);
 
   void popl(typename Traits::GPRRegister reg);
   void popl(const typename Traits::Address &address);
 
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::HasPusha>::type>
   void pushal();
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::HasPopa>::type>
   void popal();
 
   void setcc(typename Traits::Cond::BrCond condition,
              typename Traits::ByteRegister dst);
   void setcc(typename Traits::Cond::BrCond condition,
              const typename Traits::Address &address);
 
-  // All mov() overloads are tested.
   void mov(Type Ty, typename Traits::GPRRegister dst, const Immediate &src);
   void mov(Type Ty, typename Traits::GPRRegister dst,
            typename Traits::GPRRegister src);
   void mov(Type Ty, typename Traits::GPRRegister dst,
            const typename Traits::Address &src);
   void mov(Type Ty, const typename Traits::Address &dst,
            typename Traits::GPRRegister src);
   void mov(Type Ty, const typename Traits::Address &dst, const Immediate &imm);
 
   void movzx(Type Ty, typename Traits::GPRRegister dst,
@@ skipping 150 matching lines @@
 
   void cmpps(typename Traits::XmmRegister dst, typename Traits::XmmRegister src,
              typename Traits::Cond::CmppsCond CmpCondition);
   void cmpps(typename Traits::XmmRegister dst,
              const typename Traits::Address &src,
              typename Traits::Cond::CmppsCond CmpCondition);
 
   void sqrtps(typename Traits::XmmRegister dst);
   void rsqrtps(typename Traits::XmmRegister dst);
   void reciprocalps(typename Traits::XmmRegister dst);
+
   void movhlps(typename Traits::XmmRegister dst,
                typename Traits::XmmRegister src);
   void movlhps(typename Traits::XmmRegister dst,
                typename Traits::XmmRegister src);
   void unpcklps(typename Traits::XmmRegister dst,
                 typename Traits::XmmRegister src);
   void unpckhps(typename Traits::XmmRegister dst,
                 typename Traits::XmmRegister src);
   void unpcklpd(typename Traits::XmmRegister dst,
                 typename Traits::XmmRegister src);
   void unpckhpd(typename Traits::XmmRegister dst,
                 typename Traits::XmmRegister src);
 
   void set1ps(typename Traits::XmmRegister dst,
-              typename Traits::GPRRegister tmp, const Immediate &imm);
-  void shufps(typename Traits::XmmRegister dst,
-              typename Traits::XmmRegister src, const Immediate &mask);

[jvoung (off chromium), 2015/07/23 17:59:36]

oops (on the weird clustering)... is this one even used?

I imagine only the ones with the Subzero "Type Ty" as the first parameter are
actually used.

Ah, set1ps is using it. Maybe redirect w/ a dummy parameter (which is ignored
anyway)? This setup was attempting to share more of the dispatchers like
"emitIASThreeOpImmOps", where some methods like pinsr need the type while others
don't like shufps.

[John, 2015/07/27 20:35:57]

Yeah, initially I thought about removing the irregular shups method, but then I
simply decided to keep it as shufpd was also missing the type argument.

I went ahead and removed them both as they are not being used anywhere else.

+              typename Traits::GPRRegister tmp,
+              const Immediate &imm);
 
   void minpd(typename Traits::XmmRegister dst,
              typename Traits::XmmRegister src);
   void maxpd(typename Traits::XmmRegister dst,
              typename Traits::XmmRegister src);
   void sqrtpd(typename Traits::XmmRegister dst);
+
   void shufpd(typename Traits::XmmRegister dst,
               typename Traits::XmmRegister src, const Immediate &mask);
 
   void pshufd(Type Ty, typename Traits::XmmRegister dst,
               typename Traits::XmmRegister src, const Immediate &mask);
   void pshufd(Type Ty, typename Traits::XmmRegister dst,
               const typename Traits::Address &src, const Immediate &mask);
+  void shufps(typename Traits::XmmRegister dst,
+              typename Traits::XmmRegister src, const Immediate &mask);
   void shufps(Type Ty, typename Traits::XmmRegister dst,
               typename Traits::XmmRegister src, const Immediate &mask);
   void shufps(Type Ty, typename Traits::XmmRegister dst,
               const typename Traits::Address &src, const Immediate &mask);
 
   void cvtdq2ps(Type, typename Traits::XmmRegister dst,
                 typename Traits::XmmRegister src);
   void cvtdq2ps(Type, typename Traits::XmmRegister dst,
                 const typename Traits::Address &src);
 
@@ skipping 53 matching lines @@
   void insertps(Type Ty, typename Traits::XmmRegister dst,
                 const typename Traits::Address &src, const Immediate &imm);
 
   void pinsr(Type Ty, typename Traits::XmmRegister dst,
              typename Traits::GPRRegister src, const Immediate &imm);
   void pinsr(Type Ty, typename Traits::XmmRegister dst,
              const typename Traits::Address &src, const Immediate &imm);
 
   void pextr(Type Ty, typename Traits::GPRRegister dst,
              typename Traits::XmmRegister src, const Immediate &imm);
+  // The following overload is not implemented.
   void pextr(Type Ty, typename Traits::GPRRegister dst,

[jvoung (off chromium), 2015/07/23 17:59:35]

I think just delete it then, and we can add it back if needed?

              const typename Traits::Address &src, const Immediate &imm);
 
   void pmovsxdq(typename Traits::XmmRegister dst,
                 typename Traits::XmmRegister src);
 
   void pcmpeq(Type Ty, typename Traits::XmmRegister dst,
               typename Traits::XmmRegister src);
   void pcmpeq(Type Ty, typename Traits::XmmRegister dst,
               const typename Traits::Address &src);
   void pcmpgt(Type Ty, typename Traits::XmmRegister dst,
               typename Traits::XmmRegister src);
   void pcmpgt(Type Ty, typename Traits::XmmRegister dst,
               const typename Traits::Address &src);
 
   enum RoundingMode {
     kRoundToNearest = 0x0,
     kRoundDown = 0x1,
     kRoundUp = 0x2,
     kRoundToZero = 0x3
   };
   void roundsd(typename Traits::XmmRegister dst,
                typename Traits::XmmRegister src, RoundingMode mode);
 
-  void fld(Type Ty, const typename Traits::Address &src);
-  void fstp(Type Ty, const typename Traits::Address &dst);
-  void fstp(typename Traits::X87STRegister st);
+  //----------------------------------------------------------------------------
+  //
+  // Begin: X87 instructions. Only available when Traits::UsesX87.
+  //
+  //----------------------------------------------------------------------------
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
+  void fld(Type Ty, const typename T::Address &src);
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
+  void fstp(Type Ty, const typename T::Address &dst);
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
+  void fstp(typename T::X87STRegister st);
 
-  void fnstcw(const typename Traits::Address &dst);
-  void fldcw(const typename Traits::Address &src);
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
+  void fnstcw(const typename T::Address &dst);
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
+  void fldcw(const typename T::Address &src);
 
-  void fistpl(const typename Traits::Address &dst);
-  void fistps(const typename Traits::Address &dst);
-  void fildl(const typename Traits::Address &src);
-  void filds(const typename Traits::Address &src);
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
+  void fistpl(const typename T::Address &dst);
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
+  void fistps(const typename T::Address &dst);
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
+  void fildl(const typename T::Address &src);
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
+  void filds(const typename T::Address &src);
 
+  template <typename T = Traits,
+            typename = typename std::enable_if<T::UsesX87>::type>
   void fincstp();
+  //----------------------------------------------------------------------------
+  //
+  // End: X87 instructions.
+  //
+  //----------------------------------------------------------------------------
 
   void cmp(Type Ty, typename Traits::GPRRegister reg0,
            typename Traits::GPRRegister reg1);
   void cmp(Type Ty, typename Traits::GPRRegister reg,
            const typename Traits::Address &address);
   void cmp(Type Ty, typename Traits::GPRRegister reg, const Immediate &imm);
   void cmp(Type Ty, const typename Traits::Address &address,
            typename Traits::GPRRegister reg);
   void cmp(Type Ty, const typename Traits::Address &address,
            const Immediate &imm);
@@ skipping 91 matching lines @@
   void imul(Type Ty, typename Traits::GPRRegister reg, const Immediate &imm);
   void imul(Type Ty, typename Traits::GPRRegister reg,
             const typename Traits::Address &address);
 
   void imul(Type Ty, typename Traits::GPRRegister reg);
   void imul(Type Ty, const typename Traits::Address &address);
 
   void mul(Type Ty, typename Traits::GPRRegister reg);
   void mul(Type Ty, const typename Traits::Address &address);
 
+  template <class T = Traits, typename = typename std::enable_if<!T::Is64Bit>::type>

[jvoung (off chromium), 2015/07/23 17:59:35]

80 col

[John, 2015/07/27 20:35:57]

Done.

   void incl(typename Traits::GPRRegister reg);
   void incl(const typename Traits::Address &address);
 
+  template <class T = Traits, typename = typename std::enable_if<!T::Is64Bit>::type>
   void decl(typename Traits::GPRRegister reg);
   void decl(const typename Traits::Address &address);
 
   void rol(Type Ty, typename Traits::GPRRegister reg, const Immediate &imm);
   void rol(Type Ty, typename Traits::GPRRegister operand,
            typename Traits::GPRRegister shifter);
   void rol(Type Ty, const typename Traits::Address &operand,
            typename Traits::GPRRegister shifter);
 
   void shl(Type Ty, typename Traits::GPRRegister reg, const Immediate &imm);
@@ skipping 48 matching lines @@
   void ret();
   void ret(const Immediate &imm);
 
   // 'size' indicates size in bytes and must be in the range 1..8.
   void nop(int size = 1);
   void int3();
   void hlt();
   void ud2();
 
   // j(Label) is fully tested.
-  // j(ConstantRelocatable) is not tested as the test can not easily create such
-  // an argument.
   void j(typename Traits::Cond::BrCond condition, Label *label,
          bool near = kFarJump);
   void j(typename Traits::Cond::BrCond condition,
-         const ConstantRelocatable *label);
+         const ConstantRelocatable *label); // not testable.
 
   void jmp(typename Traits::GPRRegister reg);
   void jmp(Label *label, bool near = kFarJump);
-  void jmp(const ConstantRelocatable *label);
+  void jmp(const ConstantRelocatable *label); // not testable.
 
   void mfence();
 
   void lock();
   void cmpxchg(Type Ty, const typename Traits::Address &address,
                typename Traits::GPRRegister reg, bool Locked);
   void cmpxchg8b(const typename Traits::Address &address, bool Locked);
   void xadd(Type Ty, const typename Traits::Address &address,
             typename Traits::GPRRegister reg, bool Locked);
   void xchg(Type Ty, const typename Traits::Address &address,
@@ skipping 101 matching lines @@
   emitUint8(0x66);
 }
 
 } // end of namespace X86Internal
 
 } // end of namespace Ice
 
 #include "IceAssemblerX86BaseImpl.h"
 
 #endif // SUBZERO_SRC_ICEASSEMBLERX86BASE_H