Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1224173003: [osr] Increase Code::profiler_ticks to 28 bits. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[osr] Increase Code::profiler_ticks to 28 bits. Up until now we were unable to have profiler ticks beyong 255, which basically disabled OSR for moderately large functions. BUG=chromium:508741 LOG=n R=jarin@chromium.org Committed: https://crrev.com/f063a6ab42d8a2e0424b523eee57c1171981e4b8 Cr-Commit-Position: refs/heads/master@{#29597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M src/objects.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-13 10:31:20 UTC) #1
Jarin
lgtm
5 years, 5 months ago (2015-07-13 10:35:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224173003/1
5 years, 5 months ago (2015-07-13 10:39:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 10:57:45 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 10:58:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f063a6ab42d8a2e0424b523eee57c1171981e4b8
Cr-Commit-Position: refs/heads/master@{#29597}

Powered by Google App Engine
This is Rietveld 408576698