Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1224133002: Remove dart:mirrors from Sky framework (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove dart:mirrors from Sky framework Using mirrors prevents some static analysis tools from working on Sky. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/92569714ef33c1ca57447c4510ac2c7d947c3674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M sky/sdk/lib/widgets/basic.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-09 00:20:57 UTC) #1
Hixie
lgtm
5 years, 5 months ago (2015-07-09 00:21:49 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-07-09 00:24:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92569714ef33c1ca57447c4510ac2c7d947c3674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698