Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1224103002: Make AXProviderTest.HelloWorld bail without oopifs. (Closed)

Created:
5 years, 5 months ago by msw
Modified:
5 years, 5 months ago
Reviewers:
jam, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make AXProviderTest.HelloWorld bail without oopifs. This test times out flakily without oopifs enabled. Effectively disable the test without oopifs for now. This should unblock running apptests on the CQ/main. BUG=504917 TEST=Test isn't run without oopifs for now... R=jam@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/427c2f36770711c369a85f56c4a63b4036e735a9 Cr-Commit-Position: refs/heads/master@{#338073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
msw
Hey John please take a look; thanks! Hey Scott, please take a look as you ...
5 years, 5 months ago (2015-07-08 22:46:30 UTC) #1
jam
lgtm
5 years, 5 months ago (2015-07-09 16:51:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224103002/1
5 years, 5 months ago (2015-07-09 17:09:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 17:23:21 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/427c2f36770711c369a85f56c4a63b4036e735a9 Cr-Commit-Position: refs/heads/master@{#338073}
5 years, 5 months ago (2015-07-09 17:24:28 UTC) #6
msw
5 years, 5 months ago (2015-07-21 19:41:36 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1248873002/ by msw@chromium.org.

The reason for reverting is: Sadrul landed a fix for the flaky timeouts:
  https://codereview.chromium.org/1228173003
Bailing didn't resolve these flakes anyway..

Powered by Google App Engine
This is Rietveld 408576698