Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_dialog_controller.cc

Issue 1224093004: [Media Router] 2nd take on fix route response callback lifetime in UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_dialog_controller.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_dialog_controller.cc b/chrome/browser/ui/webui/media_router/media_router_dialog_controller.cc
index 5e2475b919d99ad274ce3d7858a1ce31cbb37a7c..816edc91e348506eb380d69b6c4e5a20e5504336 100644
--- a/chrome/browser/ui/webui/media_router/media_router_dialog_controller.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_dialog_controller.cc
@@ -7,6 +7,7 @@
#include <string>
#include <vector>
+#include "chrome/browser/media/router/presentation_service_delegate_impl.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/webui/constrained_web_dialog_ui.h"
#include "chrome/browser/ui/webui/media_router/media_router_ui.h"
@@ -207,7 +208,7 @@ WebContents* MediaRouterDialogController::ShowMediaRouterDialog() {
}
WebContents* MediaRouterDialogController::ShowMediaRouterDialogForPresentation(
- scoped_ptr<CreateSessionRequest> request) {
+ scoped_ptr<CreatePresentationSessionRequest> request) {
DCHECK(thread_checker_.CalledOnValidThread());
// Get the media router dialog for |initiator|, or create a new dialog
@@ -341,10 +342,11 @@ void MediaRouterDialogController::PopulateDialog(
}
if (!presentation_request_.get()) {
- PresentationServiceDelegateImpl::CreateForWebContents(initiator);
- PresentationServiceDelegateImpl* delegate =
- PresentationServiceDelegateImpl::FromWebContents(initiator);
- CHECK(delegate);
+ // TODO(imcheng): Don't create PresentationServiceDelegateImpl if it doesn't
+ // exist (crbug.com/508695).
+ base::WeakPtr<PresentationServiceDelegateImpl> delegate =
+ PresentationServiceDelegateImpl::GetOrCreateForWebContents(initiator)
+ ->GetWeakPtr();
media_router_ui->InitWithDefaultMediaSource(delegate);
} else {
media_router_ui->InitWithPresentationSessionRequest(

Powered by Google App Engine
This is Rietveld 408576698