Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1918)

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.h

Issue 1224093004: [Media Router] 2nd take on fix route response callback lifetime in UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_service_delegate_impl.h
diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.h b/chrome/browser/media/router/presentation_service_delegate_impl.h
index b7a3545fd3e967cc5635538479cc6ce2a7447e34..34e961ec27a3b37b21d2fddead7404db97c44c42 100644
--- a/chrome/browser/media/router/presentation_service_delegate_impl.h
+++ b/chrome/browser/media/router/presentation_service_delegate_impl.h
@@ -103,11 +103,11 @@ class PresentationServiceDelegateImpl
int render_frame_id,
const content::SessionStateChangedCallback& state_changed_cb) override;
- // Callback invoked when a |route| has been created or joined outside of a
- // Presentation API request. The route could be due to
+ // Callback invoked when there is a route response from CreateRoute/JoinRoute
+ // outside of a Presentation API request. This could be due to
// browser action (e.g., browser initiated media router dialog) or
// a media route provider (e.g., autojoin).
- void OnRouteCreated(const MediaRoute& route);
+ void OnRouteResponse(const MediaRoute* route, const std::string& error);
// Returns the default MediaSource for this tab if there is one.
// Returns an empty MediaSource otherwise.
@@ -160,7 +160,7 @@ class PresentationServiceDelegateImpl
const content::PresentationSessionInfo& session,
const PresentationSessionSuccessCallback& success_cb,
const PresentationSessionErrorCallback& error_cb,
- scoped_ptr<MediaRoute> route,
+ const MediaRoute* route,
const std::string& error_text);
void OnStartSessionSucceeded(
« no previous file with comments | « chrome/browser/media/router/mock_media_router.h ('k') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698