Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/media/router/media_router_mojo_impl_unittest.cc

Issue 1224093004: [Media Router] 2nd take on fix route response callback lifetime in UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router_mojo_impl_unittest.cc
diff --git a/chrome/browser/media/router/media_router_mojo_impl_unittest.cc b/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
index 7332bb9ba6f56a050351c1315fe30977cc1b8463..c62926952cbab8af3c4e67f9684ffdbee103e2a0 100644
--- a/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
+++ b/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
@@ -63,16 +63,10 @@ bool ArePresentationSessionMessagesEqual(
} // namespace
-// Adapts Invoke(), which takes a move-only scoped_ptr parameter (not mockable)
-// to a variant that accepts raw pointers instead (mock friendly).
class RouteResponseCallbackHandler {
public:
- void Invoke(scoped_ptr<MediaRoute> route, const std::string& error_text) {
- InvokeObserver(route.get(), error_text);
- }
-
- MOCK_METHOD2(InvokeObserver,
- void(MediaRoute* route, const std::string& error_text));
+ MOCK_METHOD2(Invoke,
+ void(const MediaRoute* route, const std::string& error_text));
};
class SendMessageCallbackHandler {
@@ -172,10 +166,12 @@ TEST_F(MediaRouterMojoImplTest, CreateRoute) {
}));
RouteResponseCallbackHandler handler;
- EXPECT_CALL(handler, InvokeObserver(Pointee(Equals(expected_route)), ""));
+ EXPECT_CALL(handler, Invoke(Pointee(Equals(expected_route)), ""));
+ std::vector<MediaRouteResponseCallback> route_response_callbacks;
+ route_response_callbacks.push_back(base::Bind(
+ &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->CreateRoute(kSource, kSink, GURL(kOrigin), kTabId,
- base::Bind(&RouteResponseCallbackHandler::Invoke,
- base::Unretained(&handler)));
+ route_response_callbacks);
ProcessEventLoop();
}
@@ -192,10 +188,12 @@ TEST_F(MediaRouterMojoImplTest, CreateRouteFails) {
}));
RouteResponseCallbackHandler handler;
- EXPECT_CALL(handler, InvokeObserver(nullptr, kError));
+ EXPECT_CALL(handler, Invoke(nullptr, kError));
+ std::vector<MediaRouteResponseCallback> route_response_callbacks;
+ route_response_callbacks.push_back(base::Bind(
+ &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->CreateRoute(kSource, kSink, GURL(kOrigin), kTabId,
- base::Bind(&RouteResponseCallbackHandler::Invoke,
- base::Unretained(&handler)));
+ route_response_callbacks);
ProcessEventLoop();
}
@@ -224,10 +222,12 @@ TEST_F(MediaRouterMojoImplTest, JoinRoute) {
}));
RouteResponseCallbackHandler handler;
- EXPECT_CALL(handler, InvokeObserver(Pointee(Equals(expected_route)), ""));
+ EXPECT_CALL(handler, Invoke(Pointee(Equals(expected_route)), ""));
+ std::vector<MediaRouteResponseCallback> route_response_callbacks;
+ route_response_callbacks.push_back(base::Bind(
+ &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->JoinRoute(kSource, kPresentationId, GURL(kOrigin), kTabId,
- base::Bind(&RouteResponseCallbackHandler::Invoke,
- base::Unretained(&handler)));
+ route_response_callbacks);
ProcessEventLoop();
}
@@ -243,10 +243,12 @@ TEST_F(MediaRouterMojoImplTest, JoinRouteFails) {
}));
RouteResponseCallbackHandler handler;
- EXPECT_CALL(handler, InvokeObserver(nullptr, kError));
+ EXPECT_CALL(handler, Invoke(nullptr, kError));
+ std::vector<MediaRouteResponseCallback> route_response_callbacks;
+ route_response_callbacks.push_back(base::Bind(
+ &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->JoinRoute(kSource, kPresentationId, GURL(kOrigin), kTabId,
- base::Bind(&RouteResponseCallbackHandler::Invoke,
- base::Unretained(&handler)));
+ route_response_callbacks);
ProcessEventLoop();
}
« no previous file with comments | « chrome/browser/media/router/media_router_mojo_impl.cc ('k') | chrome/browser/media/router/mock_media_router.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698