Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5131)

Unified Diff: chrome/browser/media/router/create_presentation_session_request.h

Issue 1224093004: [Media Router] 2nd take on fix route response callback lifetime in UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/router/create_presentation_session_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/create_presentation_session_request.h
diff --git a/chrome/browser/media/router/create_session_request.h b/chrome/browser/media/router/create_presentation_session_request.h
similarity index 76%
rename from chrome/browser/media/router/create_session_request.h
rename to chrome/browser/media/router/create_presentation_session_request.h
index 5bcb71f61d2a57ddfbce6761d83da3c64270fefd..a6e428181f1c113ae34b63840a2f436b4ce41104 100644
--- a/chrome/browser/media/router/create_session_request.h
+++ b/chrome/browser/media/router/create_presentation_session_request.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_MEDIA_ROUTER_CREATE_SESSION_REQUEST_H_
-#define CHROME_BROWSER_MEDIA_ROUTER_CREATE_SESSION_REQUEST_H_
+#ifndef CHROME_BROWSER_MEDIA_ROUTER_CREATE_PRESENTATION_SESSION_REQUEST_H_
+#define CHROME_BROWSER_MEDIA_ROUTER_CREATE_PRESENTATION_SESSION_REQUEST_H_
#include <string>
@@ -25,7 +25,7 @@ namespace media_router {
// MediaRouterUI. |success_cb| will be invoked when create-session
// succeeds, or |error_cb| will be invoked when create-session fails or
// the UI closes.
-class CreateSessionRequest {
+class CreatePresentationSessionRequest {
public:
using PresentationSessionSuccessCallback =
base::Callback<void(const content::PresentationSessionInfo&,
@@ -34,12 +34,13 @@ class CreateSessionRequest {
content::PresentationServiceDelegate::PresentationSessionErrorCallback;
// |presentation_url| must be valid.
- CreateSessionRequest(const std::string& presentation_url,
- const std::string& presentation_id,
- const GURL& frame_url,
- const PresentationSessionSuccessCallback& success_cb,
- const PresentationSessionErrorCallback& error_cb);
- ~CreateSessionRequest();
+ CreatePresentationSessionRequest(
+ const std::string& presentation_url,
+ const std::string& presentation_id,
+ const GURL& frame_url,
+ const PresentationSessionSuccessCallback& success_cb,
+ const PresentationSessionErrorCallback& error_cb);
+ ~CreatePresentationSessionRequest();
// Gets the MediaSource derived from this instance's presentation URL.
const MediaSource& GetMediaSource() const { return media_source_; }
@@ -63,9 +64,9 @@ class CreateSessionRequest {
PresentationSessionErrorCallback error_cb_;
bool cb_invoked_;
- DISALLOW_COPY_AND_ASSIGN(CreateSessionRequest);
+ DISALLOW_COPY_AND_ASSIGN(CreatePresentationSessionRequest);
};
} // namespace media_router
-#endif // CHROME_BROWSER_MEDIA_ROUTER_CREATE_SESSION_REQUEST_H_
+#endif // CHROME_BROWSER_MEDIA_ROUTER_CREATE_PRESENTATION_SESSION_REQUEST_H_
« no previous file with comments | « no previous file | chrome/browser/media/router/create_presentation_session_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698