Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: chrome/browser/media/router/create_session_request.cc

Issue 1224093004: [Media Router] 2nd take on fix route response callback lifetime in UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Kevin's comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/create_session_request.cc
diff --git a/chrome/browser/media/router/create_session_request.cc b/chrome/browser/media/router/create_session_request.cc
index c9516cd7e0b43cbea6420fc3e2a98fd9bb0a93f4..29e6226ed241a5be29fa393a086538f01ae16ea1 100644
--- a/chrome/browser/media/router/create_session_request.cc
+++ b/chrome/browser/media/router/create_session_request.cc
@@ -26,6 +26,10 @@ CreateSessionRequest::CreateSessionRequest(
}
CreateSessionRequest::~CreateSessionRequest() {
+ if (!cb_invoked_) {
mark a. foltz 2015/07/14 21:36:32 Or just call MaybeInvokeErrorCallback()?
+ error_cb_.Run(content::PresentationError(
+ content::PRESENTATION_ERROR_UNKNOWN, "Unknown error."));
+ }
}
void CreateSessionRequest::MaybeInvokeSuccessCallback(

Powered by Google App Engine
This is Rietveld 408576698