[Media Router] 2nd take on fix route response callback lifetime in UI.

chrome/browser/ui/webui/media_router/media_router_ui.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_MEDIA_ROUTER_MEDIA_ROUTER_UI_H_
 #define CHROME_BROWSER_UI_WEBUI_MEDIA_ROUTER_MEDIA_ROUTER_UI_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 13 matching lines @@
 
 namespace content {
 class WebContents;
 }  // namespace content
 
 namespace media_router {
 
 class IssuesObserver;
 class MediaRoute;
 class MediaRouter;
+class MediaRouterDialogCallbacks;
 class MediaRouterWebUIMessageHandler;
 class MediaRoutesObserver;
 class MediaSink;
 class MediaSinksObserver;
 class CreateSessionRequest;
 
 // Implements the chrome://media-router user interface.
 class MediaRouterUI
     : public ConstrainedWebDialogUI,
       public QueryResultManager::Observer,
       public PresentationServiceDelegateImpl::DefaultMediaSourceObserver {
  public:
   // |web_ui| owns this object and is used to initialize the base class.
   explicit MediaRouterUI(content::WebUI* web_ui);
   ~MediaRouterUI() override;
 
   // Initializes internal state (e.g. starts listening for MediaSinks) for
-  // targeting the default MediaSource (if any) of the tab. The contents of the
-  // UI will change as the default MediaSource changes. If there is a default
-  // MediaSource, then DEFAULT MediaCastMode will be added to |cast_modes_|.
-  // |source_manager|: PresentationServiceDelegateImpl of the initiator tab.
-  // Must not be null.
-  // Can only be called once.
+  // targeting the default MediaSource (if any) of the initiator tab that owns
+  // |delegate|, as well as mirroring sources of that tab.
+  // The contents of the UI will change as the default MediaSource changes.
+  // If there is a default MediaSource, then DEFAULT MediaCastMode will be
+  // added to |cast_modes_|.
+  // Init* methods can only be called once.
+  // |delegate|: PresentationServiceDelegateImpl of the initiator tab.
+  //             Must not be null.
   // TODO(imcheng): Replace use of impl with an intermediate abstract
   // interface.
-  void InitWithDefaultMediaSource(PresentationServiceDelegateImpl* delegate);
+  void InitWithDefaultMediaSource(
+      const base::WeakPtr<PresentationServiceDelegateImpl>& delegate);
 
   // Initializes internal state targeting the presentation specified in
   // |request|. Also sets up mirroring sources based on |initiator|.
   // This is different from |InitWithDefaultMediaSource| in that it does not
   // listen for default media source changes, as the UI is fixed to the source
   // in |request|.
+  // Init* methods can only be called once.
+  // |initiator|: Reference to the WebContents that initiated the dialog.
+  //              Must not be null.
+  // |presentation_request|: The presentation request. This instance will take
+  //                         ownership of it. Must not be null.
   void InitWithPresentationSessionRequest(
-      const content::WebContents* initiator,
-      scoped_ptr<CreateSessionRequest> request);
+      content::WebContents* initiator,
+      scoped_ptr<CreateSessionRequest> presentation_request);
 
   // Closes the media router UI.
   void Close();
 
   // Notifies this instance that the UI has been initialized.
   void UIInitialized();
 
   // Requests a route be created from the source determined by the preferred
   // MediaCastMode, to the sink given by |sink_id|.
   // The preferred cast mode is determined from the set of currently supported
@@ skipping 51 matching lines @@
 
   bool DoCreateRoute(const MediaSink::Id& sink_id, MediaCastMode cast_mode);
 
   // Sets the source host name to be displayed in the UI.
   // Gets cast modes from |query_result_manager_| and forwards it to UI.
   // One of the Init* functions must have been called before.
   void UpdateSourceHostAndCastModes(const GURL& frame_url);
 
   // Initializes the dialog with mirroring sources derived from |initiator|,
   // and optional |default_source| and |default_frame_url| if any.
-  void InitCommon(const content::WebContents* initiator,
+  void InitCommon(content::WebContents* initiator,
                   const MediaSource& default_source,
                   const GURL& default_frame_url);
 
-  // Invoke presentation callbacks based on |route| and |error| if the dialog
-  // was created for Presentation API.
-  void HandleRouteResponseForPresentation(const MediaRoute* route,
-                                          const std::string& error);
-
   // PresentationServiceDelegateImpl::DefaultMediaSourceObserver
   void OnDefaultMediaSourceChanged(const MediaSource& source,
                                    const GURL& frame_url) override;
 
   // Owned by the |web_ui| passed in the ctor, and guaranteed to be deleted
   // only after it has deleted |this|.
   MediaRouterWebUIMessageHandler* handler_;
 
   // These are non-null while this instance is registered to receive
   // updates from them.
   scoped_ptr<IssuesObserver> issues_observer_;
   scoped_ptr<MediaRoutesObserver> routes_observer_;
 
   // Set to true by |handler_| when the UI has been initialized.
   bool ui_initialized_;
 
   // Set to |true| if there is a pending route request for this UI.
   bool has_pending_route_request_;
 
   bool requesting_route_for_default_source_;
 
   std::vector<MediaSinkWithCastModes> sinks_;
   std::vector<MediaRoute> routes_;
   CastModeSet cast_modes_;
   GURL frame_url_;
 
   scoped_ptr<QueryResultManager> query_result_manager_;
 
-  // Only set if the UI is created as a result of Presentation API.
-  scoped_ptr<CreateSessionRequest> presentation_session_request_;
+  // If set, then the result of the next presentation route request will
+  // be handled by this object.
+  scoped_ptr<CreateSessionRequest> presentation_request_;
 
   // It's possible for PresentationServiceDelegateImpl to be destroyed before
   // this class.
   // (e.g. if a tab with the UI open is closed, then the tab WebContents will
   // be destroyed first momentarily before the UI WebContents).
   // Holding a WeakPtr to PresentationServiceDelegateImpl is the cleanest way to
   // handle this.
   // TODO(imcheng): hold a weak ptr to an abstract type instead.
   base::WeakPtr<PresentationServiceDelegateImpl> presentation_service_delegate_;
 
-  const content::WebContents* initiator_;
+  content::WebContents* initiator_;
 
   // Cached pointer to the MediaRouter for this instance's BrowserContext.
   MediaRouter* router_;
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   // Therefore |weak_factory_| must be placed at the end.
   base::WeakPtrFactory<MediaRouterUI> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaRouterUI);
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_UI_WEBUI_MEDIA_ROUTER_MEDIA_ROUTER_UI_H_