Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1224083019: Revert of Fix slow repaint object registration (Closed)

Created:
5 years, 5 months ago by Noel Gordon
Modified:
5 years, 5 months ago
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Fix slow repaint object registration (patchset #2 id:20001 of https://codereview.chromium.org/1240443003/) Reason for revert: Speculative revert: appears to have broken Linux MSAN bots. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/4413 Original issue's description: > Fix slow repaint object registration > > The LayoutView now paints background, so the special condition to accelerate > frame scrolling with fixed root background should be updated as well. > > As a drive-by fix, this CL also corrects slow repaint object accounting so > we no longer leak slow repaint object count. > > BUG=506002 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198894 TBR=vollick@chromium.org,trchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198913

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -48 lines) Patch
M Source/core/layout/LayoutBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 4 chunks +36 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Noel Gordon
Created Revert of Fix slow repaint object registration
5 years, 5 months ago (2015-07-15 03:03:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224083019/1
5 years, 5 months ago (2015-07-15 03:04:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198913
5 years, 5 months ago (2015-07-15 03:04:37 UTC) #3
Noel Gordon
5 years, 5 months ago (2015-07-15 03:14:16 UTC) #5
Noel Gordon
5 years, 5 months ago (2015-07-15 03:16:52 UTC) #7
Noel Gordon
5 years, 5 months ago (2015-07-15 04:22:51 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1234153003/ by noel@chromium.org.

The reason for reverting is: This patch was not the cause, relanding..

Powered by Google App Engine
This is Rietveld 408576698