Add support for Enums

Add support for Enums

Fixes #248

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/7daa0c70c651a979f65139a91121432d91ec9e95

[vsm, 2015-07-14 23:47:40]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2015-07-14 23:57:02]

looks good with interpolation fix

https://codereview.chromium.org/1224083017/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1224083017/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:455: '${type.name}.${fields[i].name} =
dart.const(new ${type.name}($i));'));
long line ... I think long strings confuse dartfmt ... BUT, this should probably
be rewritten to use js_ast's interpolation, otherwise it defeats the caching
mechanism. So like this:

result.add(js.statement('#.# = dart.const(new #(#));', [type.name,
js.string(fields[i].name), type.name, i]));

(if we had tagged templates in Dart, like JS does, we wouldn't need these
tricks, FWIW)

https://codereview.chromium.org/1224083017/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:460: fields.map((f) =>
js.call('${type.name}.${f.name}')).toList());
here too: js.call('#.#', type.name, js.string(f.name))

(I'm not 100% sure js.string is needed for second arg ... I forgot if it will
implicitly convert a String to a string literal in the JS AST)

https://codereview.chromium.org/1224083017/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:462: '${type.name}.values =
dart.const(dart.list(#, #));', [
here too. Use #

[vsm, 2015-07-15 00:34:03]

https://codereview.chromium.org/1224083017/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1224083017/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:455: '${type.name}.${fields[i].name} =
dart.const(new ${type.name}($i));'));
On 2015/07/14 23:57:02, John Messerly wrote:
> long line ... I think long strings confuse dartfmt ... BUT, this should
probably
> be rewritten to use js_ast's interpolation, otherwise it defeats the caching
> mechanism. So like this:
> 
> result.add(js.statement('#.# = dart.const(new #(#));', [type.name,
> js.string(fields[i].name), type.name, i]));
> 
> (if we had tagged templates in Dart, like JS does, we wouldn't need these
> tricks, FWIW)

Done.

https://codereview.chromium.org/1224083017/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:460: fields.map((f) =>
js.call('${type.name}.${f.name}')).toList());
On 2015/07/14 23:57:02, John Messerly wrote:
> here too: js.call('#.#', type.name, js.string(f.name))
> 
> (I'm not 100% sure js.string is needed for second arg ... I forgot if it will
> implicitly convert a String to a string literal in the JS AST)
> 

Done.

https://codereview.chromium.org/1224083017/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:462: '${type.name}.values =
dart.const(dart.list(#, #));', [
On 2015/07/14 23:57:02, John Messerly wrote:
> here too. Use #

Done.

[Jennifer Messerly, 2015-07-15 00:34:56]

lgtm!

[vsm, 2015-07-15 00:48:49]

Committed patchset #2 (id:20001) manually as
7daa0c70c651a979f65139a91121432d91ec9e95 (presubmit successful).