Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224083013: Gracefully handle track-less elements on updating track selection. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
haraken, fs
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Gracefully handle track-less elements on updating track selection. The media element may not have text tracks. Follow up on r198661. R=haraken BUG=457850 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
A LayoutTests/media/track/track-language-preference-no-crash.html View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/media/track/track-language-preference-no-crash-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. Various media/track crashes coming through, e.g., https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/2876/layout-test-results/media/track/track-language-preference-crash-log.txt https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpan__dbg_/1641/layout-test-results/results.html
5 years, 5 months ago (2015-07-13 06:19:51 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-07-13 06:21:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224083013/1
5 years, 5 months ago (2015-07-13 06:47:49 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 07:32:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198754

Powered by Google App Engine
This is Rietveld 408576698