Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224083010: Enable Answers in Suggest always. (Closed)

Created:
5 years, 5 months ago by Justin Donnelly
Modified:
5 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, dschuyler, groby-ooo-7-16, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Answers in Suggest always. BUG=456932, 449593 Committed: https://crrev.com/41c5b46a352171122fa3b70d6c714ae8f3234438 Cr-Commit-Position: refs/heads/master@{#338362}

Patch Set 1 #

Patch Set 2 : Fix Android compile issue #

Total comments: 2

Patch Set 3 : Respond to comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -164 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/browser/search_engines/ui_thread_search_terms_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/ui_thread_search_terms_data.cc View 1 2 1 chunk +3 lines, -10 lines 0 comments Download
M components/omnibox/browser/history_url_provider.cc View 4 chunks +0 lines, -7 lines 0 comments Download
M components/omnibox/browser/omnibox_field_trial.h View 2 chunks +0 lines, -11 lines 0 comments Download
M components/omnibox/browser/omnibox_field_trial.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M components/omnibox/browser/omnibox_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/omnibox/browser/omnibox_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/omnibox/browser/search_provider.cc View 3 chunks +22 lines, -40 lines 0 comments Download
M components/search_engines/search_terms_data.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/search_engines/search_terms_data.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/search_engines/template_url.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/search_engines/template_url_unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M components/search_engines/testing_search_terms_data.h View 3 chunks +0 lines, -5 lines 0 comments Download
M components/search_engines/testing_search_terms_data.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Justin Donnelly
Per odean turn on Answers for all platforms (it's already been 100% on Android and ...
5 years, 5 months ago (2015-07-10 17:08:41 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/1224083010/diff/20001/chrome/browser/search_engines/ui_thread_search_terms_data.cc File chrome/browser/search_engines/ui_thread_search_terms_data.cc (right): https://codereview.chromium.org/1224083010/diff/20001/chrome/browser/search_engines/ui_thread_search_terms_data.cc#newcode121 chrome/browser/search_engines/ui_thread_search_terms_data.cc:121: if (ui::GetDeviceFormFactor() == ui::DEVICE_FORM_FACTOR_PHONE) { Nit: Remove {}
5 years, 5 months ago (2015-07-10 18:33:23 UTC) #4
Justin Donnelly
https://codereview.chromium.org/1224083010/diff/20001/chrome/browser/search_engines/ui_thread_search_terms_data.cc File chrome/browser/search_engines/ui_thread_search_terms_data.cc (right): https://codereview.chromium.org/1224083010/diff/20001/chrome/browser/search_engines/ui_thread_search_terms_data.cc#newcode121 chrome/browser/search_engines/ui_thread_search_terms_data.cc:121: if (ui::GetDeviceFormFactor() == ui::DEVICE_FORM_FACTOR_PHONE) { On 2015/07/10 18:33:22, Peter ...
5 years, 5 months ago (2015-07-10 19:15:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224083010/40001
5 years, 5 months ago (2015-07-10 19:16:05 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-10 21:24:50 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:26:50 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/41c5b46a352171122fa3b70d6c714ae8f3234438
Cr-Commit-Position: refs/heads/master@{#338362}

Powered by Google App Engine
This is Rietveld 408576698