Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1224083002: Revert of [turbofan] Optimize string "length" property access based on types. (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Optimize string "length" property access based on types. (patchset #2 id:20001 of https://codereview.chromium.org/1216593003/) Reason for revert: Causes crash when running benchmarks/octane/regexp.js on ARM: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2492/steps/Benchmarks/logs/regexp Original issue's description: > [turbofan] Optimize string "length" property access based on types. > > Optimize string "length" property access based on static type > information if possible, but also optimistically optimize the access > based on type feedback from the LoadIC. > > R=jarin@chromium.org > > Committed: https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40 > Cr-Commit-Position: refs/heads/master@{#29543} TBR=mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/54572281e9be581b1a4112a7db22b9b7730c18fc Cr-Commit-Position: refs/heads/master@{#29544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -279 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +1 line, -3 lines 0 comments Download
D src/compiler/js-type-feedback-lowering.h View 1 chunk +0 lines, -62 lines 0 comments Download
D src/compiler/js-type-feedback-lowering.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +0 lines, -7 lines 0 comments Download
D test/mjsunit/compiler/string-length.js View 1 chunk +0 lines, -31 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +1 line, -30 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
Created Revert of [turbofan] Optimize string "length" property access based on types.
5 years, 5 months ago (2015-07-08 21:29:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224083002/1
5 years, 5 months ago (2015-07-08 21:29:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 21:30:02 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 21:30:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54572281e9be581b1a4112a7db22b9b7730c18fc
Cr-Commit-Position: refs/heads/master@{#29544}

Powered by Google App Engine
This is Rietveld 408576698