Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223983002: Move WriteInto to base namespace. (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, zea+watch_chromium.org, chromoting-reviews_chromium.org, browser-components-watch_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, nona+watch_chromium.org, grt+watch_chromium.org, dzhioev+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, kalyank, erikwright+watch_chromium.org, mlamouri+watch-content_chromium.org, rickyz+watch_chromium.org, penghuang+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, maniscalco+watch_chromium.org, Lei Zhang, wfh+watch_chromium.org, maxbogue+watch_chromium.org, shuchen+watch_chromium.org, tommycli, plaree+watch_chromium.org, davemoore+watch_chromium.org, tfarina, estade+watch_chromium.org, James Su, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WriteInto to base namespace. Update all callers. De-inlines the template. For some reason touching the namespaces started givin errors about DCHECK not being defined. Indeed, this header does not include logging.h. Rather than include logging in this very common header, it seems preferable to move the implementation to the .cc file. This removes support for the wstring variant and updates the callers that used it. R=ben@chromium.org, ben TBR=jschuh (sandbox_win.cc) NOPRESUBMIT=true (this patch touches code using legacy wstrings) Committed: https://chromium.googlesource.com/chromium/src/+/e3c4d1a1228e00b190ad743a83f88a2266f45238

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -109 lines) Patch
M base/base_paths_mac.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M base/ios/device_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_util.h View 1 2 chunks +15 lines, -18 lines 0 comments Download
M base/strings/string_util.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M base/strings/utf_string_conversions_unittest.cc View 1 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/web_auth_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/internal_auth.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/install_from_dmg.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/local_auth.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_after_reboot_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/install_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_country.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/app/hard_error_handler_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/omnibox/search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/portable_device_watcher_win.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M components/wifi/wifi_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_javascript_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/aead_openssl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M crypto/aes_128_gcm_helpers_nss_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M crypto/encryptor_openssl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M crypto/random_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/symmetric_key_openssl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/cast/cast_cert_validator_openssl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/android/keystore_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_string_util_icu.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/crl_set_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_objects_extractor_openssl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/jwk_serializer_openssl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/cert/x509_cert_types_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_certificate_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_util_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/entry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/entry_impl_v3.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/crypto/channel_id_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_api_string_buffer_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/token_validator_factory_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/util/nigori.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/win/imm32_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/time_format.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/win/hwnd_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223983002/20001
5 years, 5 months ago (2015-07-07 18:23:18 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/76539)
5 years, 5 months ago (2015-07-07 18:34:38 UTC) #4
Ben Goodger (Google)
lgtm
5 years, 5 months ago (2015-07-07 19:34:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223983002/20001
5 years, 5 months ago (2015-07-07 19:36:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/76575)
5 years, 5 months ago (2015-07-07 19:47:56 UTC) #10
brettw
TBR jschuh for trivial sandbox_win.cc change
5 years, 5 months ago (2015-07-07 21:31:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223983002/20001
5 years, 5 months ago (2015-07-07 21:35:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223983002/20001
5 years, 5 months ago (2015-07-07 22:26:43 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/76686)
5 years, 5 months ago (2015-07-07 22:36:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223983002/20001
5 years, 5 months ago (2015-07-07 22:43:00 UTC) #21
brettw
5 years, 5 months ago (2015-07-07 23:40:04 UTC) #23
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e3c4d1a1228e00b190ad743a83f88a2266f45238 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698