Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1223973002: Chromium's project.cfg (Closed)

Created:
5 years, 5 months ago by nodir
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromium's project.cfg Added project.cfg metadata file for chrome-infra R=sergiyb@chromium.org, phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507723 Committed: https://crrev.com/f81b1c4ae72839e2b092f5949596f484438ae4d1 Cr-Commit-Position: refs/heads/master@{#337938}

Patch Set 1 #

Patch Set 2 : # instead of // #

Patch Set 3 : updated access field syntax #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
A infra/project-config/project.cfg View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
nodir
PTAL Depends on https://codereview.chromium.org/1224913002/
5 years, 5 months ago (2015-07-07 16:53:51 UTC) #2
nodir
On 2015/07/07 16:53:51, nodir wrote: > PTAL > Depends on https://codereview.chromium.org/1224913002/ After this lands, I ...
5 years, 5 months ago (2015-07-07 17:05:41 UTC) #3
Sergiy Byelozyorov
lgtm
5 years, 5 months ago (2015-07-07 22:49:03 UTC) #4
Paweł Hajdan Jr.
LGTM
5 years, 5 months ago (2015-07-08 09:54:11 UTC) #5
nodir
https://codereview.chromium.org/1224913002/ now supports identities right in the access field
5 years, 5 months ago (2015-07-08 21:25:27 UTC) #6
nodir
On 2015/07/08 21:25:27, nodir wrote: > https://codereview.chromium.org/1224913002/ now supports identities right in the > access ...
5 years, 5 months ago (2015-07-08 21:27:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223973002/60001
5 years, 5 months ago (2015-07-08 23:10:21 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 5 months ago (2015-07-08 23:12:12 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 23:12:56 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f81b1c4ae72839e2b092f5949596f484438ae4d1
Cr-Commit-Position: refs/heads/master@{#337938}

Powered by Google App Engine
This is Rietveld 408576698