Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5613)

Unified Diff: chrome/installer/util/set_reg_value_work_item.h

Issue 1223953003: Introduce UpdateActiveSetupVersionWorkItem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a1_active_setup_onosup_addCB_API
Patch Set: Do not support negative values (operate on unsigned ints) Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/set_reg_value_work_item.h
diff --git a/chrome/installer/util/set_reg_value_work_item.h b/chrome/installer/util/set_reg_value_work_item.h
index 6ccb3773439e771ce7aa067a624d76dacff11521..14f0859604fbed683aca8e3d632c5278530dbb9e 100644
--- a/chrome/installer/util/set_reg_value_work_item.h
+++ b/chrome/installer/util/set_reg_value_work_item.h
@@ -24,25 +24,7 @@ class SetRegValueWorkItem : public WorkItem {
void Rollback() override;
- private:
- friend class WorkItem;
-
- enum SettingStatus {
- // The status before Do is called.
- SET_VALUE,
- // One possible outcome after Do(). A new value is created under the key.
- NEW_VALUE_CREATED,
- // One possible outcome after Do(). The previous value under the key has
- // been overwritten.
- VALUE_OVERWRITTEN,
- // One possible outcome after Do(). No change is applied, either
- // because we are not allowed to overwrite the previous value, or due to
- // some errors like the key does not exist.
- VALUE_UNCHANGED,
- // The status after Do and Rollback is called.
- VALUE_ROLL_BACK
- };
-
+ protected:
SetRegValueWorkItem(HKEY predefined_root,
const std::wstring& key_path,
REGSAM wow64_access,
@@ -71,6 +53,25 @@ class SetRegValueWorkItem : public WorkItem {
const std::wstring& value_name,
const GetValueFromExistingCallback& get_value_callback);
+ private:
+ friend class WorkItem;
+
+ enum SettingStatus {
+ // The status before Do is called.
+ SET_VALUE,
+ // One possible outcome after Do(). A new value is created under the key.
+ NEW_VALUE_CREATED,
+ // One possible outcome after Do(). The previous value under the key has
+ // been overwritten.
+ VALUE_OVERWRITTEN,
+ // One possible outcome after Do(). No change is applied, either
+ // because we are not allowed to overwrite the previous value, or due to
+ // some errors like the key does not exist.
+ VALUE_UNCHANGED,
+ // The status after Do and Rollback is called.
+ VALUE_ROLL_BACK
+ };
+
// Root key of the target key under which the value is set. The root key can
// only be one of the predefined keys on Windows.
HKEY predefined_root_;

Powered by Google App Engine
This is Rietveld 408576698