Make use of the new UpdateActiveSetupVersionWorkItem.

Make use of the new UpdateActiveSetupVersionWorkItem.

Sets up both:
 1) Update only the major component of the Active Setup version on
    regular update.
 2) Bump the OS_UPGRADES component of the Active Setup version
    on-os-upgrade.

BUG=488247, 502363
Committed: https://crrev.com/e7826864b2198b29f15de1b2f7a26198a7347649
Cr-Commit-Position: refs/heads/master@{#338554}

[gab, 2015-07-07 14:24:56]

gab@chromium.org changed reviewers:
+ grt@chromium.org

[gab, 2015-07-07 14:24:56]

Follow-up to https://codereview.chromium.org/1223953003/.

PTAL.

Thanks,
Gab

[grt (UTC plus 2), 2015-07-09 14:24:22]

lgtm with nits

https://codereview.chromium.org/1223933005/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/install.cc (right):

https://codereview.chromium.org/1223933005/diff/20001/chrome/installer/setup/...
chrome/installer/setup/install.cc:633: // Update the per-user
default-browser-beacon. For user-level installs this
nit: "default browser beacon" for consistency with comments in shell_util.h.

https://codereview.chromium.org/1223933005/diff/20001/chrome/installer/setup/...
chrome/installer/setup/install.cc:635: // each users' subsequent login on
system-level installs.
english nit: users' -> user's ("each user" is singular)

https://codereview.chromium.org/1223933005/diff/20001/chrome/installer/setup/...
chrome/installer/setup/install.cc:646: LOG(ERROR) << "Bumping Active Setup
Version on-os-upgrade failed.";
nit: it looks like more than half of the error messages like this in the
installer begin with "Failed to...". how do you feel about changing it to be
consistent with them?

[gab, 2015-07-09 20:41:01]

Thanks, nits addressed, waiting for resolution of
https://codereview.chromium.org/1223953003/ to land.

Cheers,
Gab

https://codereview.chromium.org/1223933005/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/install.cc (right):

https://codereview.chromium.org/1223933005/diff/20001/chrome/installer/setup/...
chrome/installer/setup/install.cc:633: // Update the per-user
default-browser-beacon. For user-level installs this
On 2015/07/09 14:24:22, grt wrote:
> nit: "default browser beacon" for consistency with comments in shell_util.h.

Done.

https://codereview.chromium.org/1223933005/diff/20001/chrome/installer/setup/...
chrome/installer/setup/install.cc:635: // each users' subsequent login on
system-level installs.
On 2015/07/09 14:24:22, grt wrote:
> english nit: users' -> user's ("each user" is singular)

Done.

https://codereview.chromium.org/1223933005/diff/20001/chrome/installer/setup/...
chrome/installer/setup/install.cc:646: LOG(ERROR) << "Bumping Active Setup
Version on-os-upgrade failed.";
On 2015/07/09 14:24:22, grt wrote:
> nit: it looks like more than half of the error messages like this in the
> installer begin with "Failed to...". how do you feel about changing it to be
> consistent with them?

Sure, kind of redundant with "Error: (...)" but my message ended with "failed"
anyways so not much better :-).

[gab, 2015-07-13 16:44:35]

FYI, the poor dependency pattern in gyp for installer/setup forces an extra
inclusion here (just like install_worker.cc and all)...

[gab, 2015-07-13 17:27:43]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2015-07-13 17:27:43]

The patchset sent to the CQ was uploaded after l-g-t-m from grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1223933005/#ps80001
(title: "merge up to r338517")

[commit-bot: I haz the power, 2015-07-13 17:32:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223933005/80001

[commit-bot: I haz the power, 2015-07-13 18:03:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 18:03:36]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

(exceeded global retry quota)

[gab, 2015-07-13 18:24:41]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2015-07-13 18:27:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223933005/80001

[commit-bot: I haz the power, 2015-07-13 19:59:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-13 20:01:02]

Patchset 5 (id:??) landed as
https://crrev.com/e7826864b2198b29f15de1b2f7a26198a7347649
Cr-Commit-Position: refs/heads/master@{#338554}