Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223863003: Factor ScrollableList out of StockList (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
hansmuller, Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Factor ScrollableList out of StockList A ScrollableList seems like a generically useful widget. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1fdd9b1a209d1fefbd94393ce7c3df4202c741e6

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -19 lines) Patch
M sky/sdk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_list.dart View 1 chunk +10 lines, -19 lines 0 comments Download
A sky/sdk/lib/widgets/scrollable_list.dart View 1 chunk +39 lines, -0 lines 4 comments Download

Messages

Total messages: 7 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-07 16:03:52 UTC) #1
Hixie
lgtm https://codereview.chromium.org/1223863003/diff/1/sky/sdk/lib/widgets/scrollable_list.dart File sky/sdk/lib/widgets/scrollable_list.dart (right): https://codereview.chromium.org/1223863003/diff/1/sky/sdk/lib/widgets/scrollable_list.dart#newcode20 sky/sdk/lib/widgets/scrollable_list.dart:20: Function itemBuilder; Builder, not Function. https://codereview.chromium.org/1223863003/diff/1/sky/sdk/lib/widgets/scrollable_list.dart#newcode22 sky/sdk/lib/widgets/scrollable_list.dart:22: int ...
5 years, 5 months ago (2015-07-07 16:49:56 UTC) #2
abarth-chromium
Committed patchset #1 (id:1) manually as 1fdd9b1a209d1fefbd94393ce7c3df4202c741e6 (presubmit successful).
5 years, 5 months ago (2015-07-07 17:03:01 UTC) #3
hansmuller
https://codereview.chromium.org/1223863003/diff/1/sky/sdk/lib/widgets/scrollable_list.dart File sky/sdk/lib/widgets/scrollable_list.dart (right): https://codereview.chromium.org/1223863003/diff/1/sky/sdk/lib/widgets/scrollable_list.dart#newcode37 sky/sdk/lib/widgets/scrollable_list.dart:37: return _buildItems(start, count).toList(growable: false); Doesn't apply toList() here eliminate ...
5 years, 5 months ago (2015-07-07 17:07:12 UTC) #5
abarth-chromium
On 2015/07/07 at 17:07:12, hansmuller wrote: > https://codereview.chromium.org/1223863003/diff/1/sky/sdk/lib/widgets/scrollable_list.dart > File sky/sdk/lib/widgets/scrollable_list.dart (right): > > https://codereview.chromium.org/1223863003/diff/1/sky/sdk/lib/widgets/scrollable_list.dart#newcode37 ...
5 years, 5 months ago (2015-07-07 17:08:56 UTC) #6
hansmuller
5 years, 5 months ago (2015-07-07 17:10:50 UTC) #7
Message was sent while issue was closed. 
On 2015/07/07 17:08:56, abarth-chromium wrote:
> On 2015/07/07 at 17:07:12, hansmuller wrote:
> >
>
https://codereview.chromium.org/1223863003/diff/1/sky/sdk/lib/widgets/scrolla...
> > File sky/sdk/lib/widgets/scrollable_list.dart (right):
> > 
> >
>
https://codereview.chromium.org/1223863003/diff/1/sky/sdk/lib/widgets/scrolla...
> > sky/sdk/lib/widgets/scrollable_list.dart:37: return _buildItems(start,
> count).toList(growable: false);
> > Doesn't apply toList() here eliminate the advantage creating an items
> Iterable?
> 
> Yeah.  :(
> 
> I've removed the use of Iterable.

Just FTR, I didn't know of sync* and yield till now. They're pretty slick.

Powered by Google App Engine
This is Rietveld 408576698