Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223843017: Remove typedefs for stdint types on WIN32. (Closed)

Created:
5 years, 5 months ago by USE s.singapati at gmail.com
Modified:
5 years, 5 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove typedefs for stdint types on WIN32. stdint.h should be available now on WIN32 / Visual Studio. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M public/platform/WebCommon.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
USE s.singapati at gmail.com
5 years, 5 months ago (2015-07-08 14:25:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223843017/1
5 years, 5 months ago (2015-07-08 14:27:24 UTC) #4
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 5 months ago (2015-07-08 14:27:28 UTC) #6
Peter Beverloo
Non-owner LGTM. Let's verify that the trybots are happy :)
5 years, 5 months ago (2015-07-08 14:28:40 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223843017/1
5 years, 5 months ago (2015-07-08 14:30:32 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-08 15:36:30 UTC) #11
USE s.singapati at gmail.com
PTAL.
5 years, 5 months ago (2015-07-09 20:41:03 UTC) #13
tkent
lgtm
5 years, 5 months ago (2015-07-09 23:21:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223843017/1
5 years, 5 months ago (2015-07-09 23:21:46 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 00:56:53 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198642

Powered by Google App Engine
This is Rietveld 408576698