Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223843003: Remove support for loading remote font faces (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove support for loading remote font faces This CL removes the ability to load remote font faces using CSS. This CL is part of a series to remove the network dependency from Sky engine. We'll likely add the ability to load custom fonts in the future, but we'll base the API on mojo::DataPipe, similar to how we load images over mojo::DataPipes today. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/9cf1c5063a0f7c3f3eaa3eb6cf3c54721645afdb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1813 lines) Patch
M sky/engine/core/core.gni View 6 chunks +0 lines, -16 lines 0 comments Download
D sky/engine/core/css/CSSCustomFontData.h View 1 chunk +0 lines, -76 lines 0 comments Download
M sky/engine/core/css/CSSFontFace.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/CSSFontFace.cpp View 3 chunks +0 lines, -54 lines 0 comments Download
M sky/engine/core/css/CSSFontFaceSource.h View 2 chunks +0 lines, -2 lines 0 comments Download
D sky/engine/core/css/CSSFontFaceSrcValue.h View 1 chunk +0 lines, -89 lines 0 comments Download
D sky/engine/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +0 lines, -109 lines 0 comments Download
M sky/engine/core/css/CSSFontSelector.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSFontSelector.cpp View 4 chunks +1 line, -4 lines 0 comments Download
M sky/engine/core/css/CSSSegmentedFontFace.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSSegmentedFontFace.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/CSSValue.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSValue.cpp View 4 chunks +0 lines, -8 lines 0 comments Download
D sky/engine/core/css/DocumentFontFaceSet.h View 1 chunk +0 lines, -43 lines 0 comments Download
D sky/engine/core/css/DocumentFontFaceSet.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/engine/core/css/DocumentFontFaceSet.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M sky/engine/core/css/FontFace.cpp View 3 chunks +0 lines, -34 lines 0 comments Download
M sky/engine/core/css/FontFaceCache.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/css/FontFaceSet.h View 1 chunk +0 lines, -142 lines 0 comments Download
D sky/engine/core/css/FontFaceSet.cpp View 1 chunk +0 lines, -421 lines 0 comments Download
D sky/engine/core/css/FontFaceSet.idl View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/engine/core/css/FontFaceSetLoadEvent.h View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/engine/core/css/FontFaceSetLoadEvent.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/engine/core/css/FontFaceSetLoadEvent.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D sky/engine/core/css/FontLoader.h View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/engine/core/css/FontLoader.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
D sky/engine/core/css/RemoteFontFaceSource.h View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/engine/core/css/RemoteFontFaceSource.cpp View 1 chunk +0 lines, -190 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 3 chunks +0 lines, -87 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/events/EventTargetFactory.in View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-05 22:12:29 UTC) #1
abarth-chromium
5 years, 5 months ago (2015-07-05 23:03:22 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9cf1c5063a0f7c3f3eaa3eb6cf3c54721645afdb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698