Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1223813006: dart2js cps: Direct access on JS arrays. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Update unit tests and remove unused functions Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
index caffb4a35406f8812e1b536444b8f7d4cc0bd580..63d1a05355ba8a9d7381f3f0d3c9f9e3193ecd3d 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
@@ -530,6 +530,27 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {
String args = node.arguments.map(visitExpression).join(', ');
return 'ApplyBuiltinOperator ${node.operator} ($args)';
}
+
+ @override
+ String visitGetLength(GetLength node) {
+ String object = visitExpression(node.object);
+ return 'GetLength($object)';
+ }
+
+ @override
+ String visitGetIndex(GetIndex node) {
+ String object = visitExpression(node.object);
+ String index = visitExpression(node.index);
+ return 'GetIndex($object, $index)';
+ }
+
+ @override
+ String visitSetIndex(SetIndex node) {
+ String object = visitExpression(node.object);
+ String index = visitExpression(node.index);
+ String value = visitExpression(node.value);
+ return 'SetIndex($object, $index, $value)';
+ }
}
/**
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart ('k') | tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698