dart2js cps: Direct access on JS arrays.

pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.ir_tracer;
 
 import 'dart:async' show EventSink;
 import 'cps_ir_nodes.dart' as cps_ir hide Function;
 import '../tracer.dart';
 
@@ skipping 174 matching lines @@
     String dummy = names.name(node);
     printStmt(dummy, "Rethrow");
   }
 
   visitUnreachable(cps_ir.Unreachable node) {
     String dummy = names.name(node);
     printStmt(dummy, 'Unreachable');
   }
 
   visitLiteralList(cps_ir.LiteralList node) {
-    String dummy = names.name(node);
     String values = node.values.map(formatReference).join(', ');
-    printStmt(dummy, "LiteralList ($values)");
+    return "LiteralList ($values)";
   }
 
   visitLiteralMap(cps_ir.LiteralMap node) {
-    String dummy = names.name(node);
     List<String> entries = new List<String>();
     for (cps_ir.LiteralMapEntry entry in node.entries) {
       String key = formatReference(entry.key);
       String value = formatReference(entry.value);
       entries.add("$key: $value");
     }
-    printStmt(dummy, "LiteralMap (${entries.join(', ')})");
+    return "LiteralMap (${entries.join(', ')})";
   }
 
   visitTypeCast(cps_ir.TypeCast node) {
     String dummy = names.name(node);
     String value = formatReference(node.value);
     String args = node.typeArguments.map(formatReference).join(', ');
     String kont = formatReference(node.continuation);
     printStmt(dummy, "TypeCast ($value ${node.type} ($args)) $kont");
   }
 
@@ skipping 148 matching lines @@
 
   @override
   visitForeignCode(cps_ir.ForeignCode node) {
     String id = names.name(node);
     String arguments = node.arguments.map(formatReference).join(', ');
     String continuation = node.continuation == null ? ''
         : ' ${formatReference(node.continuation)}';
     printStmt(id, "ForeignCode ${node.type} ${node.codeTemplate.source} "
         "$arguments $continuation");
   }
+
+  visitGetLength(cps_ir.GetLength node) {
+    String object = formatReference(node.object);
+    return 'GetLength $object';
+  }
+
+  visitGetIndex(cps_ir.GetIndex node) {
+    String object = formatReference(node.object);
+    String index = formatReference(node.index);
+    return 'GetIndex $object $index';
+  }
+
+  visitSetIndex(cps_ir.SetIndex node) {
+    String object = formatReference(node.object);
+    String index = formatReference(node.index);
+    String value = formatReference(node.value);
+    return 'SetIndex $object $index $value';
+  }
 }
 
 /**
  * Invents (and remembers) names for Continuations, Parameters, etc.
  * The names must match the conventions used by IR Hydra, e.g.
  * Continuations and Functions must have names of form B### since they
  * are visualized as basic blocks.
  */
 class Names {
   final Map<Object, String> names = {};
@@ skipping 239 matching lines @@
   }
 
   visitTypeTest(cps_ir.TypeTest node) {
     unexpectedNode(node);
   }
 
   visitApplyBuiltinOperator(cps_ir.ApplyBuiltinOperator node) {
     unexpectedNode(node);
   }
 
+  visitGetLength(cps_ir.GetLength node) {
+    unexpectedNode(node);
+  }
+
+  visitGetIndex(cps_ir.GetIndex node) {
+    unexpectedNode(node);
+  }
+
+  visitSetIndex(cps_ir.SetIndex node) {
+    unexpectedNode(node);
+  }
+
   @override
   visitForeignCode(cps_ir.ForeignCode node) {
     if (node.continuation != null) {
       addEdgeToContinuation(node.continuation);
     }
   }
 }