Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1223793008: Default download_from_google_storage.py to verbose (Closed)

Created:
5 years, 5 months ago by hinoka
Modified:
5 years, 2 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Default download_from_google_storage.py to verbose BUG=504452 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296882

Patch Set 1 #

Patch Set 2 : Revise #

Total comments: 1

Patch Set 3 : --quet #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M download_from_google_storage.py View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
hinoka
mostly harmless flag change CL, ptal.
5 years, 5 months ago (2015-07-06 18:16:54 UTC) #2
friedman1
https://codereview.chromium.org/1223793008/diff/20001/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/1223793008/diff/20001/download_from_google_storage.py#newcode364 download_from_google_storage.py:364: parser.add_option('--no-verbose', action='store_false', dest='verbose', -q, --quiet instead? and then remove ...
5 years, 5 months ago (2015-07-06 18:31:04 UTC) #4
friedman1
On 2015/07/06 18:31:04, friedman1 wrote: > https://codereview.chromium.org/1223793008/diff/20001/download_from_google_storage.py > File download_from_google_storage.py (right): > > https://codereview.chromium.org/1223793008/diff/20001/download_from_google_storage.py#newcode364 > ...
5 years, 5 months ago (2015-07-06 18:31:18 UTC) #5
iannucci
lgtm (though --quiet would be more normal :))
5 years, 5 months ago (2015-07-06 18:35:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223793008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1223793008/40001
5 years, 2 months ago (2015-09-25 18:25:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/186)
5 years, 2 months ago (2015-09-25 18:27:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223793008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1223793008/60001
5 years, 2 months ago (2015-09-25 18:28:36 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 18:33:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296882

Powered by Google App Engine
This is Rietveld 408576698