Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1223793005: Remove legacy ServiceWorker and ServiceWorkerOnFetch flags. (Closed)

Created:
5 years, 5 months ago by jeremyarcher
Modified:
5 years, 5 months ago
Reviewers:
falken, haraken, tkent, Yuki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove legacy ServiceWorker and ServiceWorkerOnFetch flags. ServiceWorker and ServiceWorkerOnFetch were previously marked as stable and so can safely be removed. (No test added: (virtual/stable/)http/serviceworker/webexposed and (virtual/stable/)webexposed still pass.) BUG=364627 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198306

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove ASSERT against legacy flag. #

Patch Set 3 : Add TODO: noting that GlobalFetch is soon to be removed. #

Patch Set 4 : Fix style bugs. #

Patch Set 5 : Patch ServiceWorkerMessageEvent.idl. #

Patch Set 6 : Fix incompatibility with ServiceWorkerMessageEvent.idl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -34 lines) Patch
M Source/modules/fetch/Body.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/fetch/Headers.idl View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/fetch/Request.idl View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/fetch/Response.idl View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/Client.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/Clients.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ExtendableEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 42 (17 generated)
falken
lgtm Might be good to add a note in the CL description that we shipped ...
5 years, 5 months ago (2015-07-06 02:02:43 UTC) #2
falken
Also, Blink CLs customarily include a test or explain in the description why there's no ...
5 years, 5 months ago (2015-07-06 02:05:51 UTC) #3
jeremyarcher
On 2015/07/06 02:05:51, falken wrote: > Also, Blink CLs customarily include a test or explain ...
5 years, 5 months ago (2015-07-06 02:30:45 UTC) #4
falken
Huh interesting, sounds like an IDL bug. +haraken is there anyway to just expose to ...
5 years, 5 months ago (2015-07-06 03:02:27 UTC) #6
jeremyarcher
5 years, 5 months ago (2015-07-06 03:15:44 UTC) #8
tkent
lgtm
5 years, 5 months ago (2015-07-06 03:15:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223793005/1
5 years, 5 months ago (2015-07-06 03:16:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_compile_dbg/builds/13500) (exceeded global retry quota)
5 years, 5 months ago (2015-07-06 03:27:56 UTC) #13
haraken
On 2015/07/06 03:02:27, falken wrote: > Huh interesting, sounds like an IDL bug. +haraken is ...
5 years, 5 months ago (2015-07-06 03:54:46 UTC) #14
haraken
5 years, 5 months ago (2015-07-06 03:55:16 UTC) #16
jeremyarcher
On 2015/07/06 03:55:16, haraken wrote: I'm able to use [Exposed=ServiceWorker], but not [Exposed=(Window GlobalFetch,ServiceWorker)] -- ...
5 years, 5 months ago (2015-07-06 03:59:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223793005/20001
5 years, 5 months ago (2015-07-06 04:02:25 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/61696)
5 years, 5 months ago (2015-07-06 04:47:19 UTC) #22
haraken
Let's wait for a comment from yukishiino@ before landing this.
5 years, 5 months ago (2015-07-06 04:51:33 UTC) #23
Yuki
On 2015/07/06 04:51:33, haraken wrote: > Let's wait for a comment from yukishiino@ before landing ...
5 years, 5 months ago (2015-07-06 05:31:20 UTC) #24
falken
On 2015/07/06 05:31:20, Yuki wrote: > On 2015/07/06 04:51:33, haraken wrote: > > Let's wait ...
5 years, 5 months ago (2015-07-06 05:49:14 UTC) #25
Yuki
On 2015/07/06 05:49:14, falken wrote: > On 2015/07/06 05:31:20, Yuki wrote: > > On 2015/07/06 ...
5 years, 5 months ago (2015-07-06 05:51:07 UTC) #26
jeremyarcher
On 2015/07/06 05:51:07, Yuki wrote: > On 2015/07/06 05:49:14, falken wrote: > > On 2015/07/06 ...
5 years, 5 months ago (2015-07-06 06:02:16 UTC) #27
haraken
On 2015/07/06 06:02:16, jeremyarcher wrote: > On 2015/07/06 05:51:07, Yuki wrote: > > On 2015/07/06 ...
5 years, 5 months ago (2015-07-06 06:03:36 UTC) #28
Yuki
Sorry, I forgot to say "lgtm".
5 years, 5 months ago (2015-07-06 06:04:24 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223793005/40001
5 years, 5 months ago (2015-07-06 06:04:53 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223793005/60001
5 years, 5 months ago (2015-07-06 06:15:32 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/49567) (exceeded global retry quota)
5 years, 5 months ago (2015-07-06 06:25:36 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223793005/100001
5 years, 5 months ago (2015-07-06 07:04:35 UTC) #41
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 08:20:22 UTC) #42
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198306

Powered by Google App Engine
This is Rietveld 408576698