Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1223763003: Revert of Concurrent sweeping of code space. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Concurrent sweeping of code space. (patchset #4 id:60001 of https://codereview.chromium.org/1222013002/) Reason for revert: [Sheriff] Increased flaky crashes. See: https://code.google.com/p/v8/issues/detail?id=4275 Original issue's description: > Concurrent sweeping of code space. > > BUG= > > Committed: https://crrev.com/3050b52f57d652dc45c8baf416e174f22dc2c159 > Cr-Commit-Position: refs/heads/master@{#29456} TBR=jochen@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/9bb826459d4c6e7a7f188d3cc126e02328813aa7 Cr-Commit-Position: refs/heads/master@{#29475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -82 lines) Patch
M src/frames.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 12 chunks +27 lines, -69 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Concurrent sweeping of code space.
5 years, 5 months ago (2015-07-06 08:25:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223763003/1
5 years, 5 months ago (2015-07-06 08:25:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 08:26:00 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 08:26:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bb826459d4c6e7a7f188d3cc126e02328813aa7
Cr-Commit-Position: refs/heads/master@{#29475}

Powered by Google App Engine
This is Rietveld 408576698