Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature) as equivalent to

net/cert/internal/signature_algorithm_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/signature_algorithm.h"
 
 #include "base/files/file_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "net/base/test_data_directory.h"
 #include "net/cert/pem_tokenizer.h"
@@ skipping 70 matching lines @@
     0x30, 0x0E,  // SEQUENCE (14 bytes)
     0x06, 0x09,  // OBJECT IDENTIFIER (9 bytes)
     0x2A, 0x86, 0x48, 0x86, 0xF7, 0x0D, 0x01, 0x01, 0x05,
     0x02, 0x01, 0x00,  // INTEGER (1 byte)
   };
   // clang-format on
   SignatureAlgorithm algorithm;
   ASSERT_FALSE(algorithm.ParseDer(der::Input(kData)));
 }
 
+// Parses a sha1WithRSASignature which contains a NULL parameters field.
+//
+//   SEQUENCE (2 elem)
+//       OBJECT IDENTIFIER  1.3.14.3.2.29
+//       NULL
+TEST(SignatureAlgorithmTest, ParseDer_sha1WithRSASignature_NullParams) {
+  // clang-format off
+  const uint8_t kData[] = {
+    0x30, 0x09,  // SEQUENCE (9 bytes)
+    0x06, 0x05,  // OBJECT IDENTIFIER (5 bytes)
+    0x2b, 0x0e, 0x03, 0x02, 0x1d,
+    0x05, 0x00,  // NULL (0 bytes)
+  };
+  // clang-format on
+  SignatureAlgorithm algorithm;
+  ASSERT_TRUE(algorithm.ParseDer(der::Input(kData)));
+
+  EXPECT_EQ(SignatureAlgorithmId::RsaPkcs1, algorithm.algorithm());
+  EXPECT_EQ(DigestAlgorithm::Sha1, algorithm.digest());
+}
+
 // Parses a sha-1WithRSAEncryption which contains values after the sequence.
 //
 //   SEQUENCE (1 elem)
 //       OBJECT IDENTIFIER  1.2.840.113549.1.1.5
 //   INTEGER  0
 TEST(SignatureAlgorithmTest, ParseDer_DataAfterSequence) {
   // clang-format off
   const uint8_t kData[] = {
     0x30, 0x0B,  // SEQUENCE (11 bytes)
     0x06, 0x09,  // OBJECT IDENTIFIER (9 bytes)
@@ skipping 351 matching lines @@
 // Tests that the parmeters returned for an invalid algorithm are null.
 TEST(SignatureAlgorithmTest, ParamsAreNullForWrongType_Invalid) {
   SignatureAlgorithm alg1;
 
   EXPECT_FALSE(alg1.ParamsForRsaPss());
 }
 
 }  // namespace
 
 }  // namespace net