Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature) as equivalent to

Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature) as equivalent to sha1WithRSAEncryption.

sha1WithRSASignature is a deprecated equivalent of
sha1WithRSAEncryption. It originates from the NIST Open
Systems Environment (OSE) Implementor's Workshop (OIW).

It is supported for compatibility with Microsoft's certificate APIs
and tools, particularly makecert.exe, which default(ed/s) to this
OID for SHA-1. See also
https://bugzilla.mozilla.org/show_bug.cgi?id=1042479

BUG=410574
Committed: https://crrev.com/eb285a379ce1166024998f299c5a758835248d86
Cr-Commit-Position: refs/heads/master@{#339148}

[eroman, 2015-07-03 16:08:31]

eroman@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2015-07-06 14:41:08]

https://codereview.chromium.org/1223763002/diff/1/net/cert/internal/signature...
File net/cert/internal/signature_algorithm.cc (right):

https://codereview.chromium.org/1223763002/diff/1/net/cert/internal/signature...
net/cert/internal/signature_algorithm.cc:31: // Fiddler, which depend on
certificates containing this OID.
Fiddler is not a Microsoft product.

// It is supported for compatibility with Microsoft's certificate APIs and
tools, particularly
// makecert.exe, which default(ed/s) to this OID for SHA-1.

[Ryan Sleevi, 2015-07-06 14:41:21]

There was also an LGTM, but I clicked too fast.

[eroman, 2015-07-06 22:53:26]

https://codereview.chromium.org/1223763002/diff/1/net/cert/internal/signature...
File net/cert/internal/signature_algorithm.cc (right):

https://codereview.chromium.org/1223763002/diff/1/net/cert/internal/signature...
net/cert/internal/signature_algorithm.cc:31: // Fiddler, which depend on
certificates containing this OID.
On 2015/07/06 14:41:08, Ryan Sleevi (slow through 7-15 wrote:
> Fiddler is not a Microsoft product.
> 
> // It is supported for compatibility with Microsoft's certificate APIs and
> tools, particularly
> // makecert.exe, which default(ed/s) to this OID for SHA-1.

Done.

[eroman, 2015-07-14 20:40:58]

For the record, I rebased this on dependent change and added a unit-test for
both the NULL parameters and absent parameters variant.

Testing with the Fiddler cert shows that the parameters are NULL encoded, and
absent parameters will be rejected.

[Ryan Sleevi, 2015-07-16 03:47:58]

LGTM % the fact that I'd love if we had more empirical data to base this on (I
suspect a CT scan wouldn't show these). But I mean, LGTM still stands.

[eroman, 2015-07-16 20:11:46]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-07-16 20:11:46]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1223763002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2015-07-16 20:12:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223763002/140001

[commit-bot: I haz the power, 2015-07-16 22:55:51]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-07-16 22:56:53]

Patchset 8 (id:??) landed as
https://crrev.com/eb285a379ce1166024998f299c5a758835248d86
Cr-Commit-Position: refs/heads/master@{#339148}