Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1223713003: Leak Detector: Add support for ScriptPromise on Blink side (Closed)

Created:
5 years, 5 months ago by hajimehoshi
Modified:
5 years, 5 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, blink-reviews-bindings_chromium.org, dglazkov+blink, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Leak Detector: Add support for ScriptPromise on Blink side This CL adds support for ScriptPromise on Blink side. This CL also adds a test that leaks ScriptPromise to LeakExpectations. BUG=506466 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198273

Patch Set 1 #

Patch Set 2 : LeakExpectations #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M LayoutTests/LeakExpectations View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromise.h View 3 chunks +9 lines, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromise.cpp View 3 chunks +22 lines, -0 lines 0 comments Download
M Source/web/WebLeakDetector.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M public/web/WebLeakDetector.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
hajimehoshi
PTAL
5 years, 5 months ago (2015-07-03 09:09:49 UTC) #2
tkent
lgtm
5 years, 5 months ago (2015-07-03 09:47:44 UTC) #3
hajimehoshi
On 2015/07/03 09:47:44, tkent wrote: > lgtm Thank you! Just in case: I've fixed LeakExpections ...
5 years, 5 months ago (2015-07-03 09:48:31 UTC) #4
haraken
LGTM
5 years, 5 months ago (2015-07-03 13:10:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223713003/40001
5 years, 5 months ago (2015-07-03 13:20:09 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198273
5 years, 5 months ago (2015-07-03 14:36:04 UTC) #9
yhirano
Don't you need to protect s_instanceCount with mutex? Don't you need to define the assignment ...
5 years, 5 months ago (2015-07-06 03:36:49 UTC) #10
yhirano
On 2015/07/06 03:36:49, yhirano wrote: > Don't you need to protect s_instanceCount with mutex? I ...
5 years, 5 months ago (2015-07-06 03:53:20 UTC) #11
hajimehoshi
5 years, 5 months ago (2015-07-06 05:05:00 UTC) #12
Message was sent while issue was closed.
On 2015/07/06 03:53:20, yhirano wrote:
> On 2015/07/06 03:36:49, yhirano wrote:
> > Don't you need to protect s_instanceCount with mutex?
> I think this leads to the test failure at
> https://code.google.com/p/chromium/issues/detail?id=506799. The test creates
> workers.

Right. I'll add a mutex or something.

Powered by Google App Engine
This is Rietveld 408576698