android_webview: Replace usage of GetActiveEntry by GetLastCommittedEntry.

android_webview: Replace usage of GetActiveEntry by GetLastCommittedEntry.

According to the bug crbug.com/273710 it can lead to security issues.

BUG=273710
R=nasko@chromium.org

Committed: https://crrev.com/85b35eb42c834539877979e2361065247342e3f8
Cr-Commit-Position: refs/heads/master@{#337315}

[Torne, 2015-07-03 09:55:50]

torne@chromium.org changed reviewers:
+ torne@chromium.org

[Torne, 2015-07-03 09:55:51]

lgtm

[nasko, 2015-07-03 10:00:59]

I do have a generic question about one of the methods, but it is outside of the
scope of this CL.

LGTM

https://codereview.chromium.org/1223643002/diff/1/android_webview/native/aw_c...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/1223643002/diff/1/android_webview/native/aw_c...
android_webview/native/aw_contents.cc:696: if (entry) {
Just a generic comment for the overall code structure: Shouldn't we be verifying
that the icon we are setting is on the correct navigation entry? It seems to me
that it is possible to start a fetch of an icon, which is slow for some reason,
then navigate very fast to a different site. If the icon fetch completes after
we've navigated to the different site, won't this stamp the icon on the wrong
site?

[Torne, 2015-07-03 10:12:59]

https://codereview.chromium.org/1223643002/diff/1/android_webview/native/aw_c...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/1223643002/diff/1/android_webview/native/aw_c...
android_webview/native/aw_contents.cc:696: if (entry) {
On 2015/07/03 10:00:59, nasko (paris) wrote:
> Just a generic comment for the overall code structure: Shouldn't we be
verifying
> that the icon we are setting is on the correct navigation entry? It seems to
me
> that it is possible to start a fetch of an icon, which is slow for some
reason,
> then navigate very fast to a different site. If the icon fetch completes after
> we've navigated to the different site, won't this stamp the icon on the wrong
> site?

Hm, possibly :/

File a bug and we can look into it?

[tfarina, 2015-07-03 15:43:22]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-07-03 15:43:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223643002/1

[commit-bot: I haz the power, 2015-07-03 15:47:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-03 15:49:01]

Patchset 1 (id:??) landed as
https://crrev.com/85b35eb42c834539877979e2361065247342e3f8
Cr-Commit-Position: refs/heads/master@{#337315}