Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1223583004: Revert of Use the upstream version of libwebp, v0.4.3. (Closed)

Created:
5 years, 5 months ago by scroggo
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Use the upstream version of libwebp, v0.4.3. (patchset #6 id:70001 of https://codereview.chromium.org/1178013008/) Reason for revert: Breaking the build e.g. http://build.chromium.org/p/client.skia/builders/Perf-Mac10.8-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Release/builds/1082/steps/build%20nanobench/logs/stdio ../../../third_party/externals/libwebp/src/utils/./endian_inl.h:51:10: error: use of unknown builtin '__builtin_bswap16' [-Wimplicit-function-declaration] return __builtin_bswap16(x); ^ 1 error generated. Original issue's description: > Use the upstream version of libwebp, v0.4.3. > > DEPS: > Update to pull v0.4.3 of libwebp from upstream > > gyp/libwebp.gyp: > Add new files, as referenced by the gyp file used by Chromium. > > resource/tests: > Add regression tests for particular images. > > BUG=skia:3442 > BUG=skia:3315 > BUG=skia:3429 > > Committed: https://skia.googlesource.com/skia/+/3aa0fb4d80c76b559ff4b82d5e569993aea06da1 TBR=djsollen@google.com,jzern@chromium.org,msarett@google.com,emmaleer@google.com,scroggo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3442 Committed: https://skia.googlesource.com/skia/+/c1d1dd738e8dda1dd439f8e2b065ec73b5c12b51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gyp/libwebp.gyp View 6 chunks +3 lines, -9 lines 0 comments Download
D resources/invalid_images/skbug3429.webp View Binary file 0 comments Download
D resources/invalid_images/skbug3442.webp View Binary file 0 comments Download
M tests/BadIcoTest.cpp View 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of Use the upstream version of libwebp, v0.4.3.
5 years, 5 months ago (2015-07-08 17:57:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223583004/1
5 years, 5 months ago (2015-07-08 17:57:16 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 17:57:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c1d1dd738e8dda1dd439f8e2b065ec73b5c12b51

Powered by Google App Engine
This is Rietveld 408576698