Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223543004: Adds better explosions, shield, and game over (Closed)

Created:
5 years, 5 months ago by viktorl
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds better explosions, shield, and game over Renames actions Fixes smaller bug in particle systems R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5b62ef735cc5e88541adab9d978d8091e2211f30

Patch Set 1 #

Total comments: 1

Patch Set 2 : git cl web #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -26 lines) Patch
M sky/sdk/example/game/lib/action.dart View 1 7 chunks +50 lines, -6 lines 0 comments Download
M sky/sdk/example/game/lib/game_demo.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/game/lib/game_demo_world.dart View 1 11 chunks +118 lines, -15 lines 0 comments Download
M sky/sdk/example/game/lib/node_with_size.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/game/lib/particle_system.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/example/game/main.dart View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
viktorl
5 years, 5 months ago (2015-07-07 12:17:28 UTC) #2
viktorl
5 years, 5 months ago (2015-07-07 12:20:29 UTC) #3
abarth-chromium
lgtm https://codereview.chromium.org/1223543004/diff/1/sky/sdk/example/game/lib/game_demo.dart File sky/sdk/example/game/lib/game_demo.dart (right): https://codereview.chromium.org/1223543004/diff/1/sky/sdk/example/game/lib/game_demo.dart#newcode8 sky/sdk/example/game/lib/game_demo.dart:8: import 'package:sky/rendering/object.dart'; Usually we sort imports as follows: ...
5 years, 5 months ago (2015-07-07 12:43:07 UTC) #5
viktorl
On 2015/07/07 at 12:43:07, abarth wrote: > lgtm > > https://codereview.chromium.org/1223543004/diff/1/sky/sdk/example/game/lib/game_demo.dart > File sky/sdk/example/game/lib/game_demo.dart (right): ...
5 years, 5 months ago (2015-07-07 13:42:17 UTC) #6
viktorl
5 years, 5 months ago (2015-07-07 13:42:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5b62ef735cc5e88541adab9d978d8091e2211f30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698