On Linux, the App Launcher is now shown in the taskbar.

On Linux, the App Launcher is now shown in the taskbar.

Widget::InitParams: Added override_show_in_taskbar value to force popup
and bubble windows (including the App Launcher) to appear in the taskbar
when they otherwise would not.

BUG=332007
TEST=Launch App Launcher. It should appear in the Unity launcher.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243585

[Matt Giuca, 2014-01-07 07:40:56]

OWNERS:
- benwells: ui/app_list/views/app_list_view.cc
- sadrul: ui/views/widget/*

[sadrul, 2014-01-07 17:20:22]

https://codereview.chromium.org/122353003/diff/1/ui/views/widget/widget.h
File ui/views/widget/widget.h (right):

https://codereview.chromium.org/122353003/diff/1/ui/views/widget/widget.h#new...
ui/views/widget/widget.h:231: bool override_show_in_taskbar;
Call this force_show_in_taskbar instead?

You need to initialize this in widget.cc

[Matt Giuca, 2014-01-08 00:48:17]

https://codereview.chromium.org/122353003/diff/1/ui/views/widget/widget.h
File ui/views/widget/widget.h (right):

https://codereview.chromium.org/122353003/diff/1/ui/views/widget/widget.h#new...
ui/views/widget/widget.h:231: bool override_show_in_taskbar;
On 2014/01/07 17:20:22, sadrul wrote:
> Call this force_show_in_taskbar instead?

Done.

> You need to initialize this in widget.cc

Done. Sorry, this was quite silly.

[benwells, 2014-01-08 02:25:52]

As discussed let's see how windows does this before adding a new field to
widget.

[benwells, 2014-01-08 03:01:24]

ui/app_list lgtm

[Matt Giuca, 2014-01-08 03:15:50]

FYI Sadrul: I just had a chat with Ben about this new flag. He thinks it
shouldn't be in Widget unless it's portable. I agree, so we had a look at the
Windows code and it turns out bubbles do show in taskbar by default, and get
manually turned off by directly writing to the HWND. So we decided it would be
best to fix Windows to not show in taskbar by default, and respect this
Widget::InitParams flag. Therefore, I think it's OK to move ahead with this CL
and fix Windows later (http://crbug.com/332277).

[sadrul, 2014-01-08 04:54:30]

Cool. LGTM

[commit-bot: I haz the power, 2014-01-08 05:17:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/122353003/210002

[commit-bot: I haz the power, 2014-01-08 17:07:59]

Change committed as 243585