Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: chrome/browser/policy/cloud_policy_browsertest.cc

Issue 12235003: Split out policy code from net/tools/testserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Saving a file, sherlock? ;) Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud_policy_browsertest.cc
diff --git a/chrome/browser/policy/cloud_policy_browsertest.cc b/chrome/browser/policy/cloud_policy_browsertest.cc
index 7f60752daca242a902cfd54e64df459a5fff6f21..5aa4e395ae5284633ca3844f510dfcdc0a7a549e 100644
--- a/chrome/browser/policy/cloud_policy_browsertest.cc
+++ b/chrome/browser/policy/cloud_policy_browsertest.cc
@@ -19,6 +19,7 @@
#include "chrome/browser/policy/policy_service.h"
#include "chrome/browser/policy/proto/chrome_settings.pb.h"
#include "chrome/browser/policy/proto/cloud_policy.pb.h"
+#include "chrome/browser/policy/test/local_policy_test_server.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_notification_types.h"
@@ -29,7 +30,6 @@
#include "content/public/browser/notification_source.h"
#include "content/public/test/test_utils.h"
#include "googleurl/src/gurl.h"
-#include "net/test/test_server.h"
#include "policy/policy_constants.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -117,17 +117,10 @@ class CloudPolicyTest : public InProcessBrowserTest {
virtual ~CloudPolicyTest() {}
virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
- // The TestServer wants the docroot as a path relative to the source dir.
- base::FilePath source;
- ASSERT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &source));
- ASSERT_TRUE(temp_dir_.CreateUniqueTempDirUnderPath(source));
+ ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
ASSERT_NO_FATAL_FAILURE(SetServerPolicy(GetEmptyPolicy()));
- test_server_.reset(
- new net::TestServer(
- net::TestServer::TYPE_HTTP,
- net::TestServer::kLocalhost,
- temp_dir_.path().BaseName()));
+ test_server_.reset(new LocalPolicyTestServer(policy_file_path()));
ASSERT_TRUE(test_server_->Start());
std::string url = test_server_->GetURL("device_management").spec();
Joao da Silva 2013/02/12 19:06:05 GetServiceURL()?
Mattias Nissler (ping if slow) 2013/02/13 11:54:10 Done.
@@ -191,12 +184,15 @@ class CloudPolicyTest : public InProcessBrowserTest {
}
void SetServerPolicy(const std::string& policy) {
- int result = file_util::WriteFile(
- temp_dir_.path().AppendASCII("device_management"),
- policy.data(), policy.size());
+ int result = file_util::WriteFile(policy_file_path(), policy.data(),
+ policy.size());
ASSERT_EQ(static_cast<int>(policy.size()), result);
}
+ FilePath policy_file_path() const {
+ return temp_dir_.path().AppendASCII("policy.json");
+ }
+
base::ScopedTempDir temp_dir_;
scoped_ptr<net::TestServer> test_server_;
};

Powered by Google App Engine
This is Rietveld 408576698