Add GetUploadStatus method to the DriveServiceInterface.

Add GetUploadStatus method to the DriveServiceInterface.

This CL adds a (stub) method GetUploadStatus to the DriveServiceInterface.
The goal of adding this method is supporting retry on receiving 5xx http
response from server for data uploading.
The callback type of the method is as same as the one for ResumeUpload.
So, it also renames ResumeUploadResponse and ResumeUploadCallback to
UploadRangeResponse and UploadRangeCallback respectively.
The params of the method is based on the experimental implementation.
The actual implementation of {gdata_wapi,drive_api}_{service,operations} should
be done in following CLs.

BUG=148632
TEST=Ran unit_tests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181245

[hidehiko, 2013-02-05 18:52:16]

Thank you for your review in advance,
- hidehiko

[hashimoto, 2013-02-06 03:46:53]

About change description
> The goal of adding the the method is supporting retry on receiving 5xx http
s/the the/this/ ?

I think it's not the time to add GetUploadStatus for the interface since no one
implements it, and no one calls it.
How about just renaming ResumeUploadCallback in this CL?
Later, you can add GetUploadStatus in another CL, with its functionality
implemented.

[hidehiko, 2013-02-06 04:28:20]

Thank you for your review.
Fixed the CL description.

Please let me share the background about this CL a bit more: Here is the
experimental implementation https://codereview.chromium.org/12218011/
Although it is neither tested well nor refactored well yet, it's about 400 LoC,
and I guess it'd be 600+ with unit tests. It looks a bit bigger.
So, I wanted to focus on discussing points by splitting the CL, to make a
progress step by step, and to reduce the review volume of total/each CL.

My plan was:
1) Add a method to the DriveServiceInterface
2) Implement the method on GData WAPI
3) Implement the retry flow on DriveUploader.
I believe it's up to teams'/reviewers' culture, but is it better for you to send
a slightly big CL including everything?
I'm fine to edit the CL as you like, so please let me know your preference.

Thanks!
- hidehiko

[hashimoto, 2013-02-06 04:40:06]

On 2013/02/06 04:28:20, hidehiko wrote:
> Thank you for your review.
> Fixed the CL description.
> 
> Please let me share the background about this CL a bit more: Here is the
> experimental implementation https://codereview.chromium.org/12218011/
> Although it is neither tested well nor refactored well yet, it's about 400
LoC,
> and I guess it'd be 600+ with unit tests. It looks a bit bigger.
> So, I wanted to focus on discussing points by splitting the CL, to make a
> progress step by step, and to reduce the review volume of total/each CL.
> 
> My plan was:
> 1) Add a method to the DriveServiceInterface
> 2) Implement the method on GData WAPI
> 3) Implement the retry flow on DriveUploader.
> I believe it's up to teams'/reviewers' culture, but is it better for you to
send
> a slightly big CL including everything?
> I'm fine to edit the CL as you like, so please let me know your preference.
> 
> Thanks!
> - hidehiko

I was worried about that reviewing an interface without users nor
implementations seems to be meaningless.
We cannot discuss if the signature of the new method is appropriate or not since
there is no clue here.
Anyways, it doesn't matter much if you are going to implement it soon.
LGTM

[hashimoto, 2013-02-06 04:44:51]

one nitty nit

https://codereview.chromium.org/12235002/diff/1/chrome/browser/google_apis/gd...
File chrome/browser/google_apis/gdata_wapi_service.h (right):

https://codereview.chromium.org/12235002/diff/1/chrome/browser/google_apis/gd...
chrome/browser/google_apis/gdata_wapi_service.h:122: 
nit: Remove this line.

[satorux1, 2013-02-06 05:52:32]

LGTM. please fix the nit found by hashimoto

[hidehiko, 2013-02-06 06:13:49]

Thank you for your review.

As for the plan, yes, I'm thinking to send a CL somehow soon.

Kazuhiro, could you kindly take a look at this CL, too?

Best regards,
- hidehiko

https://codereview.chromium.org/12235002/diff/1/chrome/browser/google_apis/gd...
File chrome/browser/google_apis/gdata_wapi_service.h (right):

https://codereview.chromium.org/12235002/diff/1/chrome/browser/google_apis/gd...
chrome/browser/google_apis/gdata_wapi_service.h:122: 
On 2013/02/06 04:44:51, hashimoto wrote:
> nit: Remove this line.

Done.

[kinaba, 2013-02-06 06:14:43]

lgtm

[commit-bot: I haz the power, 2013-02-06 19:23:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12235002/18018

[commit-bot: I haz the power, 2013-02-07 06:12:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12235002/18018

[commit-bot: I haz the power, 2013-02-07 07:20:44]

Change committed as 181245