Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1223473004: Prohibit createShadowRoot({mode: 'open'}) on existing shadow root. (Closed)

Created:
5 years, 5 months ago by kochi
Modified:
5 years, 5 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Prohibit createShadowRoot({mode: 'open'}) on existing shadow root. This implements Shadow DOM spec 8.2.2-2. https://w3c.github.io/webcomponents/spec/shadow/#widl-Element-createShadowRoot-ShadowRoot-ShadowRootInit-shadowRootInitDict > createShadowRoot ... > 2. If the context object already hosts the shadow tree, throws InvalidStateError exception. Calling createShadowRoot() without init dictionary to create multple shadow roots are still allowed for compatibility. BUG=459136 TEST=fast/dom/shadow/create-shadow-root-with-parameter.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223473004/1
5 years, 5 months ago (2015-07-06 08:03:32 UTC) #2
kochi
PTAL
5 years, 5 months ago (2015-07-06 08:06:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-06 09:30:14 UTC) #6
hayato
lgtm
5 years, 5 months ago (2015-07-07 08:46:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223473004/1
5 years, 5 months ago (2015-07-07 09:32:54 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 10:36:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198388

Powered by Google App Engine
This is Rietveld 408576698