Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223413002: remove getter for imagegenerator factory, update test (Closed)

Created:
5 years, 5 months ago by reed1
Modified:
5 years, 5 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove getter for imagegenerator factory, update test BUG=skia: Committed: https://skia.googlesource.com/skia/+/d7c05bfd7c81a835a78b4163026a4dfa573faa89

Patch Set 1 #

Total comments: 1

Patch Set 2 : document that SkData will never be null #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M include/core/SkGraphics.h View 1 chunk +4 lines, -2 lines 0 comments Download
M include/core/SkImageGenerator.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkImageGenerator.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M tests/ImageGeneratorTest.cpp View 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
reed1
ptal
5 years, 5 months ago (2015-07-09 19:19:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223413002/1
5 years, 5 months ago (2015-07-09 19:20:23 UTC) #4
mtklein
lgtm
5 years, 5 months ago (2015-07-09 19:22:16 UTC) #5
scroggo
lgtm https://codereview.chromium.org/1223413002/diff/1/include/core/SkImageGenerator.h File include/core/SkImageGenerator.h (right): https://codereview.chromium.org/1223413002/diff/1/include/core/SkImageGenerator.h#newcode225 include/core/SkImageGenerator.h:225: // It is called from NewFromEncoded() after it ...
5 years, 5 months ago (2015-07-09 19:22:57 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-09 19:41:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223413002/1
5 years, 5 months ago (2015-07-09 20:43:13 UTC) #10
reed1
On 2015/07/09 19:22:57, scroggo wrote: > lgtm > > https://codereview.chromium.org/1223413002/diff/1/include/core/SkImageGenerator.h > File include/core/SkImageGenerator.h (right): > ...
5 years, 5 months ago (2015-07-09 20:48:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223413002/20001
5 years, 5 months ago (2015-07-09 20:48:40 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 21:08:52 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d7c05bfd7c81a835a78b4163026a4dfa573faa89

Powered by Google App Engine
This is Rietveld 408576698