base/threading/post_task_and_reply_impl.h - Issue 1223393002: Add some missing virtual destructors to base classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/post_task_and_reply_impl.h

Issue 1223393002: Add some missing virtual destructors to base classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update V8SamplingProfiler Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/post_task_and_reply_impl.h

diff --git a/base/threading/post_task_and_reply_impl.h b/base/threading/post_task_and_reply_impl.h

index a5b9580e6dc43acaa59a873072d93dcae0b5c869..d21ab78de85501e4cd7dd8cf66d0e02e8176dc5f 100644

--- a/base/threading/post_task_and_reply_impl.h

+++ b/base/threading/post_task_and_reply_impl.h

@@ -25,6 +25,8 @@ namespace internal {

// may want base::WorkerPool.

class PostTaskAndReplyImpl {

public:

+ virtual ~PostTaskAndReplyImpl() = default;

// Implementation for TaskRunner::PostTaskAndReply and

// WorkerPool::PostTaskAndReply.

bool PostTaskAndReply(const tracked_objects::Location& from_here,

« no previous file with comments | « base/files/file_tracing.h ('k') | base/threading/worker_pool.cc » ('j') | no next file with comments »