Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 122333002: [View] Cleanup: Remove redundant layer()->SchedulePaint() calling (Closed)

Created:
6 years, 11 months ago by simonhong
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

[View] Cleanup: Remove redundant layer()->SchedulePaint() calling layer()->SchedulePaint() is redundant call because SetLayerBounds() always triggers Layer::SchedulePaint(). R=ben@chromium.org BUG=NONE TEST=views_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ui/views/view.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
simonhong
PTAL.
6 years, 11 months ago (2013-12-30 16:57:24 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-06 17:24:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/122333002/1
6 years, 11 months ago (2014-01-06 17:42:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241958
6 years, 11 months ago (2014-01-06 19:42:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/122333002/1
6 years, 11 months ago (2014-01-06 19:48:14 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 10:46:41 UTC) #6
Message was sent while issue was closed.
Change committed as 243245

Powered by Google App Engine
This is Rietveld 408576698