chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeRecentlyClosedTest.java - Issue 1223323012: Shore up application testing procedures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeRecentlyClosedTest.java

Issue 1223323012: Shore up application testing procedures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding function to avoid breaking downstream Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ManageBookmarkActivityTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeReferrerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeRecentlyClosedTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeRecentlyClosedTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeRecentlyClosedTest.java

index ab37e4319f647d8085cc2c573e9370d89d8238cc..3e3cf729067bd0589593c69bd952045089388f11 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeRecentlyClosedTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeRecentlyClosedTest.java

@@ -20,6 +20,7 @@ import org.chromium.chrome.browser.tabmodel.document.ActivityDelegate;

import org.chromium.chrome.browser.tabmodel.document.DocumentTabModel.Entry;

import org.chromium.chrome.browser.tabmodel.document.DocumentTabModelSelector;

import org.chromium.chrome.test.util.ActivityUtils;

+import org.chromium.chrome.test.util.ApplicationTestUtils;

import org.chromium.chrome.test.util.DisableInTabbedMode;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

@@ -96,13 +97,13 @@ public class DocumentModeRecentlyClosedTest extends DocumentModeTestBase {

assertEquals("Wrong tab count", 2, selector.getTotalTabCount());

// Return to the Android Home screen.

- launchHomeIntent(mContext);

+ ApplicationTestUtils.fireHomeScreenIntent(mContext);

assertEquals("Wrong tab count", 2, selector.getTotalTabCount());

// Remove the fake task, then bring Chrome back to the foreground to make the

// DocumentTabModel update.

activityDelegate.mExtraRegularTask = null;

- launchMainIntent(mContext);

+ ApplicationTestUtils.launchChrome(mContext);

assertTrue(CriteriaHelper.pollForCriteria(new Criteria() {

@Override

public boolean isSatisfied() {