No longer using non-antialiased fast path for lines when antialiasing is on.

No longer using non-antialiased fast path for lines when antialiasing is on.

BUG=skia:3776
Committed: https://skia.googlesource.com/skia/+/330bb956fddc0729c26204c872de9284c90ab7a5

[ethannicholas, 2015-07-09 16:46:15]

ethannicholas@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[robertphillips, 2015-07-09 17:20:59]

https://codereview.chromium.org/1223323003/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1223323003/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:398: 
needs_antialiasing since static

https://codereview.chromium.org/1223323003/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:404: if (count == 2) {
How does this work if, say, the x coords were equal and integer but the y coords
were not ?

https://codereview.chromium.org/1223323003/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:442: if (width > 0 || paint.getPathEffect() ||
paint.getMaskFilter() || (paint.isAntiAlias() &&
line this up ?

[ethannicholas, 2015-07-09 17:40:21]

https://codereview.chromium.org/1223323003/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1223323003/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:404: if (count == 2) {
On 2015/07/09 17:20:59, robertphillips wrote:
> How does this work if, say, the x coords were equal and integer but the y
coords
> were not ?

It will not use antialiasing in that case. That was deliberate, as I reasoned
that the case of lines that should be sharp turning into two-pixel-wide blurs is
a far worse problem than the two pixels on the end not being antialiased. Is
this a big enough problem to worry about a more complex fix?

https://codereview.chromium.org/1223323003/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:442: if (width > 0 || paint.getPathEffect() ||
paint.getMaskFilter() || (paint.isAntiAlias() &&
On 2015/07/09 17:20:59, robertphillips wrote:
> line this up ?

Done.

[robertphillips, 2015-07-13 17:06:06]

lgtm - you might want to wait for the Gold log jam to clear about before landing
though.

[ethannicholas, 2015-07-17 13:32:37]

The CQ bit was checked by ethannicholas@google.com

[commit-bot: I haz the power, 2015-07-17 13:32:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223323003/40001

[commit-bot: I haz the power, 2015-07-17 13:44:05]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/330bb956fddc0729c26204c872de9284c90ab7a5