pkg/dart2js_incremental/lib/caching_compiler.dart - Issue 1223293002: dart2js: Rename old emitter to full emitter and make it its own library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dart2js_incremental/lib/caching_compiler.dart

Issue 1223293002: dart2js: Rename old emitter to full emitter and make it its own library. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/dart2js_incremental/lib/caching_compiler.dart

diff --git a/pkg/dart2js_incremental/lib/caching_compiler.dart b/pkg/dart2js_incremental/lib/caching_compiler.dart

index 50893ef0b86f32607ea8eb745a978c13f02c96aa..aeab05acc6176c37e8c6c70bb0e19cdff83bc1db 100644

--- a/pkg/dart2js_incremental/lib/caching_compiler.dart

+++ b/pkg/dart2js_incremental/lib/caching_compiler.dart

@@ -65,7 +65,7 @@ Future<Compiler> reuseCompiler(

null);

JavaScriptBackend backend = compiler.backend;

- OldEmitter emitter = backend.emitter.emitter;

+ full.Emitter emitter = backend.emitter.emitter;

// Much like a scout, an incremental compiler is always prepared. For

// mixins, classes, and lazy statics, at least.

@@ -102,7 +102,7 @@ Future<Compiler> reuseCompiler(

..enqueuer.codegen.hasEnqueuedReflectiveStaticFields = false

..compilationFailed = false;

JavaScriptBackend backend = compiler.backend;

- OldEmitter emitter = backend.emitter.emitter;

+ full.Emitter emitter = backend.emitter.emitter;

// TODO(ahe): Seems this cache only serves to tell

// [emitter.invalidateCaches] if it was invoked on a full compile (in

« no previous file with comments | « pkg/compiler/lib/src/use_unused_api.dart ('k') | pkg/dart2js_incremental/lib/dart2js_incremental.dart » ('j') | no next file with comments »