pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart - Issue 1223293002: dart2js: Rename old emitter to full emitter and make it its own library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart

Issue 1223293002: dart2js: Rename old emitter to full emitter and make it its own library. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/js_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart

index 0c3ae733a4fc94ccc307f23bae03754b8a1cc6b8..6e4f4182b4a3a071071ecd52e372db89f6bdc904 100644

--- a/pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart

@@ -47,13 +47,13 @@ class Emitter implements emitterTask.Emitter {

return _emitter.emitProgram(program);

}

- // TODO(floitsch): copied from OldEmitter. Adjust or share.

+ // TODO(floitsch): copied from full emitter. Adjust or share.

@override

bool isConstantInlinedOrAlreadyEmitted(ConstantValue constant) {

return _emitter.isConstantInlinedOrAlreadyEmitted(constant);

}

- // TODO(floitsch): copied from OldEmitter. Adjust or share.

+ // TODO(floitsch): copied from full emitter. Adjust or share.

@override

int compareConstants(ConstantValue a, ConstantValue b) {

return _emitter.compareConstants(a, b);

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/js_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart » ('j') | no next file with comments »