Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2887)

Unified Diff: build/toolchain/android/BUILD.gn

Issue 1223273005: Remove explicit "mkdir -p" from Android postlink command (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn15
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/android/BUILD.gn
diff --git a/build/toolchain/android/BUILD.gn b/build/toolchain/android/BUILD.gn
index f7f47ff229754565fa635b32477e950acf9b5142..1380c4abc0cecb4302ee763959abaf13c17a278d 100644
--- a/build/toolchain/android/BUILD.gn
+++ b/build/toolchain/android/BUILD.gn
@@ -64,20 +64,17 @@ template("android_gcc_toolchain") {
android_strip = "${tool_prefix}strip"
- mkdir_command = "mkdir -p lib.stripped"
strip_command =
"$android_strip --strip-unneeded -o $temp_stripped_soname $soname"
replace_command = "if ! cmp -s $temp_stripped_soname $stripped_soname; then mv $temp_stripped_soname $stripped_soname; fi"
- postsolink = "$mkdir_command && $strip_command && $replace_command"
+ postsolink = "$strip_command && $replace_command"
solink_outputs = [ stripped_soname ]
# We make the assumption that the gcc_toolchain will produce an exe with
# the following definition.
exe = "{{root_out_dir}}/{{target_output_name}}{{output_extension}}"
stripped_exe = "exe.stripped/$exe"
- mkdir_command = "mkdir -p exe.stripped"
- strip_command = "$android_strip --strip-unneeded -o $stripped_exe $exe"
- postlink = "$mkdir_command && $strip_command"
+ postlink = "$android_strip --strip-unneeded -o $stripped_exe $exe"
link_outputs = [ stripped_exe ]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698