Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/android/java/AndroidManifest.xml

Issue 1223263009: Disable hardware acceleration for ChromeActivities on low-end devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/AndroidManifest.xml
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
index 8ba2b22b453a01ddf73cc42003102961e8e5f92a..5757837282e5e3993bfbfbb4b6fec8f8f192342a 100644
--- a/chrome/android/java/AndroidManifest.xml
+++ b/chrome/android/java/AndroidManifest.xml
@@ -111,6 +111,9 @@ by a child template that "extends" this file.
<!-- Note: Set android:hardwareAccelerated to "false" in the ".Main"
newt (away) 2015/07/16 19:46:16 This comment in thoroughly out of date. Please rem
activity below to go into software, browser tiling mode.
+ Note: All activities directly or indirectly derived from ChromeActivity
+ must specify android:hardwareAccelerated="false".
+
Since this activity (shown in the launcher) and the application
(shown in Android's Settings/Apps list) share the same label, we
do not specify one here to allow it to inherit from the app. -->
@@ -196,7 +199,7 @@ by a child template that "extends" this file.
android:persistableMode="persistAcrossReboots"
android:autoRemoveFromRecents="false"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc"
- android:hardwareAccelerated="true">
+ android:hardwareAccelerated="false">
</activity>
<activity-alias android:name="com.google.android.apps.chrome.document.DocumentActivity"
android:targetActivity="org.chromium.chrome.browser.document.DocumentActivity"
@@ -210,7 +213,7 @@ by a child template that "extends" this file.
android:persistableMode="persistNever"
android:autoRemoveFromRecents="false"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc"
- android:hardwareAccelerated="true">
+ android:hardwareAccelerated="false">
</activity>
<activity-alias android:name="com.google.android.apps.chrome.document.IncognitoDocumentActivity"
android:targetActivity="org.chromium.chrome.browser.document.IncognitoDocumentActivity"
@@ -220,7 +223,7 @@ by a child template that "extends" this file.
android:exported="false"
android:windowSoftInputMode="adjustResize"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc"
- android:hardwareAccelerated="true">
+ android:hardwareAccelerated="false">
</activity>
<activity android:name="org.chromium.chrome.browser.ChromeTabbedActivity"
android:theme="@style/MainTheme"
@@ -229,7 +232,7 @@ by a child template that "extends" this file.
android:windowSoftInputMode="adjustResize"
android:launchMode="singleTask"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc"
- android:hardwareAccelerated="true">
+ android:hardwareAccelerated="false">
</activity>
<activity android:name="org.chromium.chrome.browser.multiwindow.MultiInstanceChromeTabbedActivity"
android:theme="@style/MainTheme"
@@ -237,7 +240,7 @@ by a child template that "extends" this file.
android:windowBackground="@drawable/window_background"
android:windowSoftInputMode="adjustResize"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc"
- android:hardwareAccelerated="true">
+ android:hardwareAccelerated="false">
</activity>
<activity android:name="org.chromium.chrome.browser.sync.ui.PassphraseActivity"
android:theme="@style/MainTheme"
@@ -276,7 +279,7 @@ by a child template that "extends" this file.
</activity>
<activity android:name="org.chromium.chrome.browser.EmbedContentViewActivity"
android:theme="@style/ThemeWithActionBar"
- android:hardwareAccelerated="true"
+ android:hardwareAccelerated="false"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc">
</activity>
<activity android:name="org.chromium.chrome.browser.prerender.PrerenderAPITestActivity"
@@ -328,7 +331,7 @@ by a child template that "extends" this file.
android:documentLaunchMode="intoExisting"
android:windowSoftInputMode="adjustResize"
android:persistableMode="persistNever"
- android:hardwareAccelerated="true"
+ android:hardwareAccelerated="false"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc">
</activity>
<activity-alias android:name="com.google.android.apps.chrome.webapps.WebappActivity"
@@ -343,7 +346,7 @@ by a child template that "extends" this file.
android:launchMode="singleTask"
android:windowSoftInputMode="adjustResize"
android:persistableMode="persistNever"
- android:hardwareAccelerated="true"
+ android:hardwareAccelerated="false"
android:taskAffinity="{{ manifest_package }}.webapps.WebappActivity{{ i }}"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc">
</activity>

Powered by Google App Engine
This is Rietveld 408576698