Common Name Mismatch Handler For WWW Subdomain Mismatch case

chrome/browser/captive_portal/captive_portal_browsertest.cc

Index: chrome/browser/captive_portal/captive_portal_browsertest.cc
diff --git a/chrome/browser/captive_portal/captive_portal_browsertest.cc b/chrome/browser/captive_portal/captive_portal_browsertest.cc
index 72fe2bf7b665ec2e384d736a057bdc899c56a846..dcfdc605774b6fa51f2184343b4a110c5180cbc9 100644
--- a/chrome/browser/captive_portal/captive_portal_browsertest.cc
+++ b/chrome/browser/captive_portal/captive_portal_browsertest.cc
@@ -55,6 +55,7 @@
 #include "content/public/test/browser_test_utils.h"
 #include "net/base/net_errors.h"
 #include "net/http/transport_security_state.h"
+#include "net/test/test_certificate_data.h"
 #include "net/test/url_request/url_request_failed_job.h"
 #include "net/test/url_request/url_request_mock_http_job.h"
 #include "net/url_request/url_request.h"
@@ -345,8 +346,8 @@ void URLRequestTimeoutOnDemandJob::FailOrAbandonJobsOnIOThread(
       DCHECK(job->request()->url().SchemeIsCryptographic());
       net::SSLInfo info;
       info.cert_status = net::CERT_STATUS_COMMON_NAME_INVALID;
-      info.cert = new net::X509Certificate(
-          "bad.host", "CA", base::Time::Max(), base::Time::Max());
+      info.cert = net::X509Certificate::CreateFromBytes(

[mmenke, 2015/07/31 15:16:49]

While you're here, mind adding whatever header X509Certificate comes from?

[Bhanu Dev, 2015/07/31 18:20:38]

Done.

+          reinterpret_cast<const char*>(google_der), sizeof(google_der));

[mmenke, 2015/07/31 15:16:49]

google_der is a global constant?  Its naming violates the google style guide. 
HAte to block this on a refactor, but this seems pretty bad to me.

[Bhanu Dev, 2015/07/31 18:20:38]

I have added a bug for this at crbug.com/515969. But, just saw that they're not
global constants.(rsleevi's comment in bug) Thanks.

       job->NotifySSLCertificateError(info, true);
     }
   }