Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5993)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 1223233002: Common Name Mismatch Handler For WWW Subdomain Mismatch case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor Changes: Removing test code Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index 122de1bec21a8ab27cd991da9490482e40c3c979..570b7813b5b0074222cd6d8df7c4f5c2fd086fad 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -67,7 +67,8 @@ class SSLBlockingPage : public SecurityInterstitialPage {
int options_mask,
const base::Time& time_triggered,
scoped_ptr<SSLCertReporter> ssl_cert_reporter,
- const base::Callback<void(bool)>& callback);
+ const base::Callback<void(bool)>& callback,
+ const GURL& suggested_url);
// InterstitialPageDelegate method:
InterstitialPageDelegate::TypeID GetTypeForTesting() const override;
@@ -106,6 +107,8 @@ class SSLBlockingPage : public SecurityInterstitialPage {
base::Callback<void(bool)> callback_;
+ void NavigateToSuggestedURL() const;
meacer 2015/07/28 01:18:06 nit: OpenSuggestedURL? Also, maybe add a comment.
Bhanu Dev 2015/07/30 02:39:10 Done.
+
const int cert_error_;
const net::SSLInfo ssl_info_;
// There are two ways for the user to override an interstitial:
@@ -130,6 +133,10 @@ class SSLBlockingPage : public SecurityInterstitialPage {
scoped_ptr<CertReportHelper> cert_report_helper_;
+ // Guide the user to this URL, when there is a common name mismatch error
+ // and it can be handled.
+ const GURL suggested_url_;
+
// Which type of interstitial this is.
enum SSLInterstitialReason {
SSL_REASON_SSL,

Powered by Google App Engine
This is Rietveld 408576698