chrome/browser/ssl/ssl_browser_tests.cc - Issue 1223233002: Common Name Mismatch Handler For WWW Subdomain Mismatch case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 1223233002: Common Name Mismatch Handler For WWW Subdomain Mismatch case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolving Comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/ssl_blocking_page.cc ('K') | « chrome/browser/ssl/ssl_blocking_page.cc ('k') | chrome/browser/ssl/ssl_error_classification.h » ('j') | chrome/browser/ssl/ssl_error_classification.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index 31a3f6a13dbca0299249c2e0d90f7547f2626427..cc49e245ff6b4578f102d45c5c9f27f79e94a738 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -2233,9 +2233,10 @@ class SSLBlockingPageIDNTest : public SecurityInterstitialIDNTest {

net::SSLInfo ssl_info;

ssl_info.cert = new net::X509Certificate(

request_url.host(), "CA", base::Time::Max(), base::Time::Max());

- return new SSLBlockingPage(

- contents, net::ERR_CERT_CONTAINS_ERRORS, ssl_info, request_url, 0,

- base::Time::NowFromSystemTime(), nullptr, base::Callback<void(bool)>());

+ return new SSLBlockingPage(contents, net::ERR_CERT_CONTAINS_ERRORS,

+ ssl_info, request_url, 0,

+ base::Time::NowFromSystemTime(), nullptr,

+ base::Callback<void(bool)>(), GURL());

}

};