Common Name Mismatch Handler For WWW Subdomain Mismatch case

chrome/browser/ssl/ssl_error_handler.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SSL_SSL_ERROR_HANDLER_H_
 #define CHROME_BROWSER_SSL_SSL_ERROR_HANDLER_H_
 
 #include <string>
 
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/ssl/common_name_mismatch_handler.h"
 #include "chrome/browser/ssl/ssl_cert_reporter.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 #include "net/ssl/ssl_info.h"
 #include "url/gurl.h"
 
 namespace content {
 class RenderViewHost;
@@ skipping 30 matching lines @@
                              int options_mask,
                              scoped_ptr<SSLCertReporter> ssl_cert_reporter,
                              const base::Callback<void(bool)>& callback);
 
   static void SetInterstitialDelayTypeForTest(InterstitialDelayType delay);
 
   typedef base::Callback<void(content::WebContents*)> TimerStartedCallback;
   static void SetInterstitialTimerStartedCallbackForTest(
       TimerStartedCallback* callback);
 
+  // This method gets the result of whether the suggested url is valid. Displays

[meacer, 2015/07/09 17:58:56]

nit: Drop "This method "

[Bhanu Dev, 2015/07/11 04:00:43]

Done.

+  // common name mismatch interstitial or ssl interstitial accordingly.
+  void CommonNameMismatchHandlerCallback(
+      const CommonNameMismatchHandler::Results& results);
+
  protected:
   SSLErrorHandler(content::WebContents* web_contents,
                   int cert_error,
                   const net::SSLInfo& ssl_info,
                   const GURL& request_url,
                   int options_mask,
                   scoped_ptr<SSLCertReporter> ssl_cert_reporter,
                   const base::Callback<void(bool)>& callback);
 
   ~SSLErrorHandler() override;
 
   // Called when an SSL cert error is encountered. Triggers a captive portal
   // check and fires a one shot timer to wait for a "captive portal detected"
   // result to arrive.
   void StartHandlingError();
   const base::OneShotTimer<SSLErrorHandler>& get_timer() const {
     return timer_;
   }
 
  private:
   // Callback for the one-shot timer. When the timer expires, an SSL error is
   // immediately displayed.
   void OnTimerExpired();
 
   // These are virtual for tests:
   virtual void CheckForCaptivePortal();
   virtual void ShowCaptivePortalInterstitial(const GURL& landing_url);
-  virtual void ShowSSLInterstitial();
+  virtual void ShowSSLInterstitial(const GURL& suggested_url);
 
   // content::NotificationObserver:
   void Observe(
       int type,
       const content::NotificationSource& source,
       const content::NotificationDetails& details) override;
 
   // content::WebContentsObserver:
   void DidStartNavigationToPendingEntry(
       const GURL& url,
       content::NavigationController::ReloadType reload_type) override;
 
+  // Timer duration for common name mismatch handler url check.
+  const int common_name_handler_delay_in_seconds = 3;

[meacer, 2015/07/09 17:58:56]

You'll need a non-const value for this so that you can change it in tests. I
think you should just reuse the existing methods and variables for the captive
portal check: (GetInterstitialDisplayDelay and SetInterstitialDelayTypeForTest)

[Bhanu Dev, 2015/07/11 04:00:43]

Done.

+
   content::WebContents* web_contents_;
   const int cert_error_;
   const net::SSLInfo ssl_info_;
   const GURL request_url_;
   const int options_mask_;
   base::Callback<void(bool)> callback_;
 
   content::NotificationRegistrar registrar_;
   base::OneShotTimer<SSLErrorHandler> timer_;
 
+  scoped_ptr<CommonNameMismatchHandler> common_name_mismatch_handler_;
+
   scoped_ptr<SSLCertReporter> ssl_cert_reporter_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLErrorHandler);
 };
 
 #endif  // CHROME_BROWSER_SSL_SSL_ERROR_HANDLER_H_